Intl test improvements #13797
Merged
Intl test improvements #13797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samdark
commented
Mar 17, 2017
samdark
commented
| Q | A |
|---|---|
| Is bugfix? | no |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes/no |
| Fixed issues | - |
…riants for Russian currencies and transliteration
samdark
requested review from
dynasource,
cebe,
klimov-paul,
SilverFire and
arogachev
dynasource
approved these changes
Mar 17, 2017
tests/IsOneOfAssert.php
Outdated
| * @param $allowedValues | ||
| */ | ||
| public function __construct($allowedValues) | ||
| { |
There was a problem hiding this comment.
Could be type hinted on array as from PHP 5.1
|
Looks better https://gitlab.com/yiisoft/yii2/builds/12492438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.