Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-suite fails with ICU 57.1 #13750

Closed
schmunk42 opened this issue Mar 10, 2017 · 17 comments
Closed

Test-suite fails with ICU 57.1 #13750

schmunk42 opened this issue Mar 10, 2017 · 17 comments
Assignees
Milestone

Comments

@schmunk42
Copy link
Contributor

What steps will reproduce the problem?

Run tests on a system with ICU 57.1
#13360 (comment)

What is the expected result?

Green tests

What do you get instead?

Red tests, see https://travis-ci.org/yiisoft/yii2-docker/jobs/209762936#L2178

Additional info

Q A
Yii version 2.0.11.2
PHP version Any
Operating system Alpine LInux (Docker)

Running them on i.e. Debian with 52.1 is fine. See https://gitlab.com/yiisoft/yii2-docker/builds/11975020 or https://travis-ci.org/yiisoft/yii2-docker/builds/209762928

Ignore the green alpine-7.1 build

@schmunk42 schmunk42 changed the title Test fail with ICU 57.1 Test-suite fails with ICU 57.1 Mar 10, 2017
@samdark samdark self-assigned this Mar 10, 2017
@samdark samdark added this to the 2.0.12 milestone Mar 10, 2017
@samdark
Copy link
Member

samdark commented Mar 14, 2017

@schmunk42 I've adjusted tests a bit to tolerate valid ICU differences.

@schmunk42
Copy link
Contributor Author

There are still some issues left: https://gitlab.com/yiisoft/yii2/builds/12180932

@schmunk42
Copy link
Contributor Author

It looks to me like it does not use the new variations in the test data: https://gitlab.com/yiisoft/yii2/builds/12180932 - like it has no effect to check the ICU version.

Or do I get that wrong?

@samdark
Copy link
Member

samdark commented Mar 16, 2017

Weird but seems so.

@samdark
Copy link
Member

samdark commented Mar 16, 2017

I can re-do it other way.

@samdark
Copy link
Member

samdark commented Mar 17, 2017

#13797

@samdark samdark modified the milestones: 2.0.13, 2.0.12 Apr 26, 2017
@samdark samdark modified the milestones: 2.0.13, 2.0.15 Sep 29, 2017
@samdark samdark added the type:bug Bug label Feb 3, 2018
@samdark
Copy link
Member

samdark commented Feb 3, 2018

@schmunk42 is that still the case?

@antgubarev
Copy link
Contributor

Actual ICU version is 60.2

@schmunk42
Copy link
Contributor Author

@amarox With which OS and PHP versions are you testing?

@schmunk42
Copy link
Contributor Author

@samdark Could you review #15559 - it would greatly help for testing issues like this.

@samdark
Copy link
Member

samdark commented Feb 5, 2018

#15559 merged.

@schmunk42
Copy link
Contributor Author

So I think this can be closed.

@schmunk42
Copy link
Contributor Author

@amarox With which OS and PHP versions are you testing?

@amarox Are you on ArchLinux?

@antgubarev
Copy link
Contributor

ICU updated manually

@schmunk42
Copy link
Contributor Author

@amarox Do you see errors on 60.2? Do we need to test it?

@antgubarev
Copy link
Contributor

checked. no errors.

@cebe cebe modified the milestones: 2.0.15, 2.0.14 Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants