added dockerized test setup #13360

schmunk42 · 2017-01-10T10:54:42Z

Q	A
Is bugfix?	no
New feature?	yes
Breaks BC?	yes
Tests pass?	it's about testing
Fixed issues	relates #13047

essential

optional

additonal tools/dev-image(?)
isolation in GitLab CI

related: Codeception/Codeception#3739

samdark · 2017-01-10T11:03:28Z

tests/docker-compose.yml

+      - POSTGRES_PASSWORD=postgres
+
+  #sqlsrv:
+  #  image: microsoft/mssql-server-linux


Are you going to enable it as well?

Yes, I tried, but you need to install some additional system packages first - it just did not work right away. Let me know if you've some input here, I've never worked with MSSQL.

I have no experience with dockerizing it or even running it under Linux.

schmunk42 · 2017-01-14T11:35:21Z

TL;dr

So, theoretically this is a complete setup. You can view an example GitHub build here - they're not green yet.

I've split the setup into 3 stacks: default, mssql and cubrid. We can add more later. There are 4 test jobs, which are run in parallel. Whenever possible I've used pre-built images.

Currently there are different base-images, I intentionally left it in this state, because it shows a few issues we should sort out, before continuing.

Choosing a base image

There are several options how to create a Docker image for testing. You can build from different base-images, like php, composer or codeception/codeception or debian, ubuntu, ....
Currently there's no official Yii image, another option.

Basically you need to install the required PHP-extensions for Yii (that's why some tests fail, because this is just a vanilla PHP) and for some suites also additional extensions.

I'd say it's not really possible to build a Yii image with all extensions (pdo_mssql, pdo_cubrid, xcache etc...) just because some are not available for debian, etc... So I'd just choose what works, i.e. codemix base-image, custom build for cubrid, pre-build for mssql.

In tests, there are dependencies from i.e. log suite to db, which make tests fail which would actually run on a vanilla PHP. I thought about also putting them into group db, WDYT?
These components might also be reviewed for decoupling.

Depending on how you wanna build the image you also need composer and some other tools, like npm or yarn, i.e. for testing asset bundling via webpack. But that's a separate topic.

Tests do not pass on Travis now, this is just because of changed DB credentials and hosts (should be easy to fix)

While I could easily write 5x times more :) I'd like stop here and also CC: @mikehaertl and @motin - your experience and feedback about Docker, PHP & Yii is very welcome.

Would be really nice if you could give it a try and just report if the things start to work.

motin · 2017-01-19T10:18:47Z

Love it. Every open source project should offer a way of running database-dependent tests without having to follow extensive complicated instructions on how to set up databases and credentials. @schmunk42, please supply a single shell-script that will run all tests with all database engines in sequence and I'll verify that it works over here :)

Squashed commits: [c42f30c] updated base image, added docs & local test script [88f0c40] debug [6220c94] fixed network isolation [c63c7c3] test mssql only on test/mssql branch [74efc78] fixed isolation in after_script [02b895b] updated test setup [3335f39] updated retry [bd123b2] updated service checks [45e4c90] updated build [d54da7a] updated after_script [5a4c726] 🏭 wait for mysql [08db878] fixed typo [ea53c1e] updated build stages [9807ce3] fixed typos [cf9f64e] fixed mssql testing [08001d6] added db create for mssql [62f6b65] run travis (gitlab simulation) only in travis branch [cf63da4] streamlined build [76808ac] updated test jobs [18d79b5] fixed test error [7b2bce6] updated build & composer.lock [244623a] updated build [86bd71b] fixed cleanup [86ab2e8] fixed cleanup [091d4b8] fixed tests [2d315b5] fixed build config [2913644] fixed project names [f53b823] refactored build config [5a791fb] refactored docker db-tests [b4479b0] revert [a975fa5] updated gitlab build [4e4e5e4] updated mssql setup [d6ff03b] added sleep workaround [578b102] removed host volumes in test [928f50b] fixed path [967ab10] updated tests [520f317] bootstrap cubrid [5f245e1] 🏭 fixed cubrid tests [940dbbc] 🏭 pinned cubrid version 9.3.6.0002 [8d5ea69] 📝 dockerized test commands [9954b54] updated cubrid [fb3afac] updated docs [3f63ced] updated isolation [bdc3c83] 🏭 build cubrid [b777911] 🏭 disabled mssql, updated cubrid [36534e7] added travis-a-like stage [6546f02] updated GitLab build [c046096] updated test setup - added mssql and cubrid stack [5a0e635] disabled host-volume [75cf342] fixed test [8de0794] fixed testing [465d27a] added stages [63aa950] added script [68eecef] fixed typo [00e4b88] updated Docker build [f9072cc] added dockerized test setup

schmunk42 · 2017-01-19T17:21:49Z

This should be ready to try out locally.
Let me know if you've questions...

…docker-testing

schmunk42 · 2017-01-21T11:26:35Z

Example build pipelines

https://git.hrzg.de/schmunk42/yii2/pipelines/18231 (all, except oci & mssql)
https://git.hrzg.de/schmunk42/yii2/builds/72942 (like travis but twice as fast)

- added git files to dockerignore - updated local testing - updated build on branches

…docker-testing

updated build branches See merge request !1

schmunk42 · 2017-01-24T22:43:26Z

tests/data/config.php

@@ -16,29 +16,29 @@
 $config = [
    'databases' => [
        'cubrid' => [
-            'dsn' => 'cubrid:dbname=demodb;host=localhost;port=33000',
+            'dsn' => 'cubrid:dbname=demodb;host=cubrid;port=33000',


@cebe @samdark How should we handle this? Using a separate file for Docker tests. It's theoretically possible to fake this with Docker, but we would loose a lot of isolation & stability.

What is the problem here?

schmunk42 · 2017-01-24T22:48:22Z

Example build: https://git.hrzg.de/schmunk42/yii2/pipelines/18450/builds

schmunk42 · 2017-01-28T12:38:56Z

You can't really fake localhost in the dockerized setup. It also makes no sense to build the database servers into the PHP image. Can we just create another config file, which is loaded via ENV bar? Von meinem iPhone gesendet

…

Am 28.01.2017 um 11:58 schrieb Alexander Makarov ***@***.***>: @samdark commented on this pull request. In tests/data/config.php: > @@ -16,29 +16,29 @@ $config = [ 'databases' => [ 'cubrid' => [ - 'dsn' => 'cubrid:dbname=demodb;host=localhost;port=33000', + 'dsn' => 'cubrid:dbname=demodb;host=cubrid;port=33000', What is the problem here? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

samdark · 2017-01-28T15:36:24Z

Yes, we can. Why not?

schmunk42 · 2017-01-28T16:47:34Z

Was just a discussion :) I'll add it to the PR... Von meinem iPhone gesendet

…

Am 28.01.2017 um 16:36 schrieb Alexander Makarov ***@***.***>: Yes, we can. Why not? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

…docker-testing # Conflicts: # tests/framework/db/sqlite/QueryBuilderTest.php

schmunk42 · 2017-02-16T14:32:47Z

About composer.lock - https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file

You should update it from time to time and always for a release. A developer who wants to run update can still do so. You also need it for some CI related tasks, here and there.

cebe · 2017-02-16T15:01:48Z

tests/framework/console/controllers/DbMessageControllerTest.php

@@ -1,6 +1,10 @@
 <?php
 namespace yiiunit\framework\console\controllers;

+/**
+ * @group db


this must be on the class phpdoc, not here.

…docker-testing

schmunk42 · 2017-02-16T15:54:50Z

Current build state:

tests/mysql https://gitlab.com/yiisoft-contrib/yii2/pipelines/6519636/builds
tests/pgsql https://gitlab.com/yiisoft-contrib/yii2/pipelines/6519650/builds

schmunk42 · 2017-02-17T19:13:50Z

Anything more?

samdark · 2017-02-20T22:56:30Z

I think it's OK to merge. @cebe ?

cebe · 2017-03-06T14:53:02Z

Merged, thank you for this great addition! :)

schmunk42 · 2017-03-06T16:01:11Z

You're welcome :)

Auto-pull also works already, see: https://gitlab.com/yiisoft-contrib/yii2/pipelines/6851144
Do these tests also fail in Travis? I need to look that up.

I'll look after the tests from time to time. db, cache and mysql are green AFAIR.

You can push i.e. to tests/pgsql on gitlab.com to trigger the PostgreTest suite.

The "exotic" databases still need some testing of the testing...

samdark · 2017-03-06T19:27:07Z

@schmunk42 is there a way to integrate these tests with GitHub? Some failures are about differences in intl/ICU data used. gitlab has newer version. Tests should be adjusted.

schmunk42 · 2017-03-06T19:41:07Z

It's set up to sync hourly.

samdark · 2017-03-06T20:18:03Z

Yes, I know. I've meant displaying links and results in pull requests etc.

schmunk42 · 2017-03-06T20:51:30Z

Hmm, there's a build badge, but further integration is limited AFAIR.
Related: https://gitlab.com/gitlab-org/gitlab-ce/issues/2595

[update]
Asked this question in an issue ... https://gitlab.com/gitlab-org/gitlab-ce/issues/29099

schmunk42 · 2017-03-10T17:34:27Z

is there a way to integrate these tests with GitHub? Some failures are about differences in intl/ICU data used. gitlab has newer version. Tests should be adjusted.

@samdark You could run tests also on Travis, but we didn't want to touch the existing Travis setup.
Looks like there's no support for multiple files: travis-ci/travis-ci#3540

Could work with a travis/docker branch though.

samdark · 2017-03-10T18:19:25Z

I see. I'd let travis alone as it is. It is sometimes weird but that gives additional cases to fix which is good.

schmunk42 · 2017-03-10T19:56:54Z

OK, we'll be able to see these issues better, when we have the base images. Since we then can test multiple versions easily.

CC: @mikehaertl

samdark reviewed Jan 10, 2017

View reviewed changes

cebe self-assigned this Jan 12, 2017

cebe added the type:test label Jan 12, 2017

SilverFire added this to the website and infrastructure milestone Jan 14, 2017

schmunk42 force-pushed the feature/docker-testing branch from 45e4c90 to f5ab85c Compare January 19, 2017 17:01

schmunk42 added 6 commits January 19, 2017 22:47

updated docs

cc1f398

fixed cleanup

8893eca

fixed network setup

25cc36c

fixed tuple

4db2ff9

Merge commit '3f66fb6cdfd498a119bfb34562549d07ff2ff9e0' into feature/…

b6d14ca

…docker-testing

run cubrid only on branch tests/cubrid

bd956aa

schmunk42 added 2 commits January 24, 2017 15:41

updated build

478331e

- added git files to dockerignore - updated local testing - updated build on branches

Merge commit 'd4d6c1dabf555e6f14a668df6fcc515bceef2830' into feature/…

7718868

…docker-testing

schmunk42 force-pushed the feature/docker-testing branch from 2b702dd to 7718868 Compare January 24, 2017 14:42

schmunk42 and others added 2 commits January 24, 2017 20:45

updated build branches

3bcbee3

Merge branch 'feature/docker-testing' into 'tests/mysql'

3f2eaf0

updated build branches See merge request !1

schmunk42 commented Jan 24, 2017

View reviewed changes

schmunk42 added 4 commits February 9, 2017 16:24

Merge commit '95b7ffc066c03f2510ef4e6681e1ddf1494e916f' into feature/…

0a4fdf2

…docker-testing # Conflicts: # tests/framework/db/sqlite/QueryBuilderTest.php

added separate docker config for testing

7b43cf0

use custom docker config in dockerized tests

0dd1ed6

removed TODOs

f96ea4c

added build trigger example

7a4666f

schmunk42 added 2 commits February 16, 2017 15:42

added db group to test

ec8daa0

Merge branch 'feature/docker-testing' into tests/mysql

dc356fb

cebe requested changes Feb 16, 2017

View reviewed changes

dynasource removed their request for review February 16, 2017 15:06

schmunk42 added 3 commits February 16, 2017 16:46

added groups to tests

9f95f71

Merge commit '22972b86dbcc6e010dc90df921090e713521f0b9' into feature/…

2fad692

…docker-testing

Merge branch 'tests/mysql' into feature/docker-testing

0e0caef

samdark approved these changes Feb 17, 2017

View reviewed changes

SilverFire approved these changes Feb 20, 2017

View reviewed changes

schmunk42 and others added 3 commits March 6, 2017 14:16

moved Dockerfile(s) to test folders

acf7c85

updated changelog

a1fd4d3

Merge branch 'master' into feature/docker-testing

ff4cde1

cebe approved these changes Mar 6, 2017

View reviewed changes

cebe merged commit 2339e2f into yiisoft:master Mar 6, 2017

schmunk42 mentioned this pull request Mar 7, 2017

added GitLab build badge #13721

Closed

schmunk42 mentioned this pull request Mar 10, 2017

Test-suite fails with ICU 57.1 #13750

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added dockerized test setup #13360

added dockerized test setup #13360

schmunk42 commented Jan 10, 2017 •

edited

Loading

samdark Jan 10, 2017

schmunk42 Jan 10, 2017 •

edited

Loading

samdark Jan 10, 2017

schmunk42 commented Jan 14, 2017

motin commented Jan 19, 2017

schmunk42 commented Jan 19, 2017

schmunk42 commented Jan 21, 2017

schmunk42 Jan 24, 2017

samdark Jan 28, 2017

schmunk42 commented Jan 24, 2017

schmunk42 commented Jan 28, 2017 via email

samdark commented Jan 28, 2017

schmunk42 commented Jan 28, 2017 via email

schmunk42 commented Feb 16, 2017

cebe Feb 16, 2017

schmunk42 commented Feb 16, 2017

schmunk42 commented Feb 17, 2017

samdark commented Feb 20, 2017

cebe commented Mar 6, 2017

schmunk42 commented Mar 6, 2017

samdark commented Mar 6, 2017

schmunk42 commented Mar 6, 2017

samdark commented Mar 6, 2017

schmunk42 commented Mar 6, 2017 •

edited

Loading

schmunk42 commented Mar 10, 2017

samdark commented Mar 10, 2017

schmunk42 commented Mar 10, 2017

added dockerized test setup #13360

added dockerized test setup #13360

Conversation

schmunk42 commented Jan 10, 2017 • edited Loading

samdark Jan 10, 2017

Choose a reason for hiding this comment

schmunk42 Jan 10, 2017 • edited Loading

Choose a reason for hiding this comment

samdark Jan 10, 2017

Choose a reason for hiding this comment

schmunk42 commented Jan 14, 2017

TL;dr

Choosing a base image

motin commented Jan 19, 2017

schmunk42 commented Jan 19, 2017

schmunk42 commented Jan 21, 2017

schmunk42 Jan 24, 2017

Choose a reason for hiding this comment

samdark Jan 28, 2017

Choose a reason for hiding this comment

schmunk42 commented Jan 24, 2017

schmunk42 commented Jan 28, 2017 via email

samdark commented Jan 28, 2017

schmunk42 commented Jan 28, 2017 via email

schmunk42 commented Feb 16, 2017

cebe Feb 16, 2017

Choose a reason for hiding this comment

schmunk42 commented Feb 16, 2017

schmunk42 commented Feb 17, 2017

samdark commented Feb 20, 2017

cebe commented Mar 6, 2017

schmunk42 commented Mar 6, 2017

samdark commented Mar 6, 2017

schmunk42 commented Mar 6, 2017

samdark commented Mar 6, 2017

schmunk42 commented Mar 6, 2017 • edited Loading

schmunk42 commented Mar 10, 2017

samdark commented Mar 10, 2017

schmunk42 commented Mar 10, 2017

schmunk42 commented Jan 10, 2017 •

edited

Loading

schmunk42 Jan 10, 2017 •

edited

Loading

schmunk42 commented Mar 6, 2017 •

edited

Loading