Explicitly mark nullable parameters (#305)

yiisoft · Feb 25, 2025 · 42ea454 · 42ea454
1 parent 0e065ae
commit 42ea454
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -31,6 +31,7 @@
 - Enh #299: Convert database types to lower case (@Tigrov)
 - Enh #300: Replace `DbArrayHelper::getColumn()` with `array_column()` (@Tigrov)
 - New #301: Add `IndexType` class (@Tigrov)
+- Bug #305: Explicitly mark nullable parameters (@vjik)
 
 ## 1.3.0 March 21, 2024
 

diff --git a/src/Connection.php b/src/Connection.php
@@ -23,7 +23,7 @@
  */
 final class Connection extends AbstractPdoConnection
 {
-    public function createCommand(string $sql = null, array $params = []): PdoCommandInterface
+    public function createCommand(?string $sql = null, array $params = []): PdoCommandInterface
     {
         $command = new Command($this);
 
@@ -55,7 +55,7 @@ public function createTransaction(): TransactionInterface
      * @throws InvalidCallException
      * @throws Throwable
      */
-    public function getLastInsertID(string $sequenceName = null): string
+    public function getLastInsertID(?string $sequenceName = null): string
     {
         if ($sequenceName === null) {
             throw new InvalidArgumentException('Oracle not support lastInsertId without sequence name.');

diff --git a/src/DDLQueryBuilder.php b/src/DDLQueryBuilder.php
@@ -25,8 +25,8 @@ public function addForeignKey(
         array|string $columns,
         string $referenceTable,
         array|string $referenceColumns,
-        string $delete = null,
-        string $update = null
+        ?string $delete = null,
+        ?string $update = null
     ): string {
         $sql = 'ALTER TABLE ' . $this->quoter->quoteTableName($table)
             . ' ADD CONSTRAINT ' . $this->quoter->quoteColumnName($name)

diff --git a/src/DMLQueryBuilder.php b/src/DMLQueryBuilder.php
@@ -158,7 +158,7 @@ protected function prepareInsertValues(string $table, array|QueryInterface $colu
         return parent::prepareInsertValues($table, $columns, $params);
     }
 
-    public function resetSequence(string $table, int|string $value = null): string
+    public function resetSequence(string $table, int|string|null $value = null): string
     {
         $tableSchema = $this->schema->getTableSchema($table);