Set default connection settings for tests (#304)

yiisoft · Feb 23, 2025 · 0e065ae · 0e065ae
1 parent 04fedd1
commit 0e065ae
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 19 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -95,13 +95,6 @@ jobs:
 
       - name: Run tests with phpunit with code coverage.
         run: vendor/bin/phpunit --coverage-clover=coverage.xml --colors=always
-        env:
-          YII_ORACLE_SID: XE
-          YII_ORACLE_DATABASE: YIITEST
-          YII_ORACLE_HOST: localhost
-          YII_ORACLE_PORT: 1521
-          YII_ORACLE_USER: system
-          YII_ORACLE_PASSWORD: root
 
       - name: Upload coverage to Codecov.
         uses: codecov/codecov-action@v3

diff --git a/.github/workflows/mutation.yml b/.github/workflows/mutation.yml
@@ -84,9 +84,3 @@ jobs:
           vendor/bin/roave-infection-static-analysis-plugin --threads=2 --ignore-msi-with-no-mutations --only-covered
         env:
           STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}
-          YII_ORACLE_SID: XE
-          YII_ORACLE_DATABASE: YIITEST
-          YII_ORACLE_HOST: localhost
-          YII_ORACLE_PORT: 1521
-          YII_ORACLE_USER: system
-          YII_ORACLE_PASSWORD: root
diff --git a/tests/Support/TestTrait.php b/tests/Support/TestTrait.php
@@ -75,31 +75,31 @@ private function getDriver(): PdoDriverInterface
 
     private static function getSid(): string
     {
-        return getenv('YII_ORACLE_SID') ?? '';
+        return getenv('YII_ORACLE_SID') ?: 'XE';
     }
 
     private static function getDatabaseName(): string
     {
-        return getenv('YII_ORACLE_DATABASE') ?? '';
+        return getenv('YII_ORACLE_DATABASE') ?: 'YIITEST';
     }
 
     private static function getHost(): string
     {
-        return getenv('YII_ORACLE_HOST') ?? '';
+        return getenv('YII_ORACLE_HOST') ?: 'localhost';
     }
 
     private static function getPort(): string
     {
-        return getenv('YII_ORACLE_PORT') ?? '';
+        return getenv('YII_ORACLE_PORT') ?: '1521';
     }
 
     private static function getUsername(): string
     {
-        return getenv('YII_ORACLE_USER') ?? '';
+        return getenv('YII_ORACLE_USER') ?: 'system';
     }
 
     private static function getPassword(): string
     {
-        return getenv('YII_ORACLE_PASSWORD') ?? '';
+        return getenv('YII_ORACLE_PASSWORD') ?: 'root';
     }
 }