Remove source stage for amd-bootc #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multi-stage build has too many stages. During the installation of
the `amggpu-dkms` package, the modules are built and installed in
`/lib/modules/${KERNEL_VERSION}`. If the installation of the package is
done in the `driver-toolkit` image, the extra dependencies are very
limited. This change removes the `source` stage and installs the
`amdgpu-dkms` package on top of `driver-toolkit`.
The `amdgpu-dkms` packages installs the modules in
`/lib/modules/${KERNEL_VERSION}/extra` and these are the only modules in
that folder. The `amdgpu-dkms-firmware` package is installed as a
dependency of `admgpu-dkms` and it installs the firwmare files in
`/lib/firmware/updates/amdgpu·`. So, this change removes the in-tree
`amdgpu` modules and firmware, then copies the ones generated by DKMS in
the `builder` stage.
The change also moves the repository definitions to the `repos.d` folder
and adds the AMD public key to verify the signatures of the AMD RPMs.
The users call a wrapper script called `ilab` to hide the `instructlab`
container image and the command line options. This change copies the
file from `nvidia-bootc` and adjusts the logic. The main change is that
`/dev/kfd` and `/dev/dri` devices are passed to the container, instead
of `nvidia.com/gpu=all`. The `ilab` wrapper is copied in the `amd-bootc`
image.
The Makefile is also modified to reflect these changes.
Signed-off-by: Fabien Dupont <[email protected]>
fabiendupont
force-pushed
the
amd-bootc-use-out-of-tree-drivers
branch
from
45d0a2c to
d33c8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-stage build has too many stages. During the installation of the
amggpu-dkmspackage, the modules are built and installed in/lib/modules/${KERNEL_VERSION}. If the installation of the package is done in thedriver-toolkitimage, the extra dependencies are very limited. This change removes thesourcestage and installs theamdgpu-dkmspackage on top ofdriver-toolkit.The
amdgpu-dkmspackages installs the modules in/lib/modules/${KERNEL_VERSION}/extraand these are the only modules in that folder. Theamdgpu-dkms-firmwarepackage is installed as a dependency ofadmgpu-dkmsand it installs the firwmare files in/lib/firmware/updates/amdgpu·. So, this change removes the in-treeamdgpumodules and firmware, then copies the ones generated by DKMS in thebuilderstage.The change also moves the repository definitions to the
repos.dfolder and adds the AMD public key to verify the signatures of the AMD RPMs.The users call a wrapper script called
ilabto hide theinstructlabcontainer image and the command line options. This change copies the file fromnvidia-bootcand adjusts the logic. The main change is that/dev/kfdand/dev/dridevices are passed to the container, instead ofnvidia.com/gpu=all. Theilabwrapper is copied in theamd-bootcimage.The Makefile is also modified to reflect these changes.