updating AMD bootc image #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yevgeny-shnaidman
commented
Aug 26, 2024
yevgeny-shnaidman
commented
- using OOT driver and firmware instead of in-tree
- moving to DKMS and ROCM 6.1.2 version
yevgeny-shnaidman
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum,
cgwalters and
Gregory-Pereira
as code owners
1) using OOT driver and firmware instead of in-tree 2) moving to DKMS and ROCM 6.1.2 version Signed-off-by: Yevgeny Shnaidman <[email protected]>
yevgeny-shnaidman
force-pushed
the
yevgeny/amd-bootc-6.1.2
branch
from
0f7a8a9 to
062841f
Compare
|
/cc @fabiendupont |
The multi-stage build has too many stages. During the installation of
the `amggpu-dkms` package, the modules are built and installed in
`/lib/modules/${KERNEL_VERSION}`. If the installation of the package is
done in the `driver-toolkit` image, the extra dependencies are very
limited. This change removes the `source` stage and installs the
`amdgpu-dkms` package on top of `driver-toolkit`.
The `amdgpu-dkms` packages installs the modules in
`/lib/modules/${KERNEL_VERSION}/extra` and these are the only modules in
that folder. The `amdgpu-dkms-firmware` package is installed as a
dependency of `admgpu-dkms` and it installs the firwmare files in
`/lib/firmware/updates/amdgpu·`. So, this change removes the in-tree
`amdgpu` modules and firmware, then copies the ones generated by DKMS in
the `builder` stage.
The change also moves the repository definitions to the `repos.d` folder
and adds the AMD public key to verify the signatures of the AMD RPMs.
The users call a wrapper script called `ilab` to hide the `instructlab`
container image and the command line options. This change copies the
file from `nvidia-bootc` and adjusts the logic. The main change is that
`/dev/kfd` and `/dev/dri` devices are passed to the container, instead
of `nvidia.com/gpu=all`. The `ilab` wrapper is copied in the `amd-bootc`
image.
The Makefile is also modified to reflect these changes.
Signed-off-by: Fabien Dupont <[email protected]>
|
Instead of commenting here, I submitted a pull request in @yevgeny-shnaidman's repository: yevgeny-shnaidman#1. |
…vers Remove source stage for amd-bootc
|
LGTM |
rhatdan
reviewed
Aug 28, 2024
| ARG INSTRUCTLAB_IMAGE="quay.io/ai-lab/instructlab-amd:latest" | ||
| ARG BASEIMAGE="quay.io/centos-bootc/centos-bootc:stream9" | ||
| ARG DRIVER_TOOLKIT_IMAGE="quay.io/ai-lab/nvidia-builder:latest" |
There was a problem hiding this comment.
Does this make sense? Using nvidia-builder on amd-bootc?
There was a problem hiding this comment.
this is a driver-toolkit image, which contains all the package needed for kernel module compilation. So, it is related to a kernel version, and does not contain any packages that might be specific to nvidia. The name unfortunate, but this is what we have right now
There was a problem hiding this comment.
We have discussed moving the bootc images out of the ai-lab-recipes repository. One of the changes would be to have a quay.io/<org>/driver-toolkit:<kernel-version>. The driver toolkit images could be hosted in the quay.io/fedora and quay.io/centos orgs.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.