Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openai): support all o series models #1031

Merged
merged 1 commit into from
Jan 5, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lua/avante/providers/openai.lua
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,18 @@ M.get_user_message = function(opts)
)
end

M.is_o_series_model = function(model)
return model and string.match(model, "^o%d+") ~= nil
end

M.parse_messages = function(opts)
local messages = {}
local provider = P[Config.provider]
local base, _ = P.parse_config(provider)

-- NOTE: Handle the case where the selected model is the `o1` model
-- "o1" models are "smart" enough to understand user prompt as a system prompt in this context
if base.model and string.find(base.model, "o1") then
if M.is_o_series_model(base.model) then
table.insert(messages, { role = "user", content = opts.system_prompt })
else
table.insert(messages, { role = "system", content = opts.system_prompt })
Expand Down Expand Up @@ -150,9 +154,10 @@ M.parse_curl_args = function(provider, code_opts)
headers["Authorization"] = "Bearer " .. api_key
end

-- NOTE: When using "o1" set the supported parameters only
-- NOTE: When using "o" series set the supported parameters only
local stream = true
if base.model and string.find(base.model, "o1") then
if M.is_o_series_model(base.model) then
body_opts.max_completion_tokens = body_opts.max_tokens
body_opts.max_tokens = nil
body_opts.temperature = 1
end
Expand Down