fix(openai): support all o series models
#1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, since `max_completion_tokens` was not set for `o` series models, the completion request will time out sometimes. This makes sure it converts the `max_tokens` parameter to `max_completion_tokens` for `o` series models. I tested this change with `gpt-4o-mini`, `o1-mini` and `o3-mini`, and they all still work as expected.
brewinski
pushed a commit
to brewinski/avante.nvim
that referenced
this pull request
Jan 10, 2025
Before this change, since `max_completion_tokens` was not set for `o` series models, the completion request will time out sometimes. This makes sure it converts the `max_tokens` parameter to `max_completion_tokens` for `o` series models. I tested this change with `gpt-4o-mini`, `o1-mini` and `o3-mini`, and they all still work as expected.
brewinski
pushed a commit
to brewinski/avante.nvim
that referenced
this pull request
Jan 10, 2025
Before this change, since `max_completion_tokens` was not set for `o` series models, the completion request will time out sometimes. This makes sure it converts the `max_tokens` parameter to `max_completion_tokens` for `o` series models. I tested this change with `gpt-4o-mini`, `o1-mini` and `o3-mini`, and they all still work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, since
max_completion_tokenswas not set foroseries models, the completion request sometimes times out. This PR makes sure that it converts themax_tokensparameter tomax_completion_tokensforoseries models.I tested this change with
gpt-4o-mini,o1-miniando3-mini, and they all still work as expected.