Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (starknet): add batching functionality for claim_payment #184

Merged
merged 12 commits into from
Mar 27, 2024
Merged

feat (starknet): add batching functionality for claim_payment #184

merged 12 commits into from
Mar 27, 2024

Conversation

taturosati
Copy link
Contributor

Added 2 functions:

  • claim_payment_batch on escrow.cairo
  • claimPaymentBatch on PaymentRegistry.sol

This functions allow market maker to batch payment claims in order to save in gas costs.
Added tests for this two functions.

@taturosati taturosati linked an issue Mar 19, 2024 that may be closed by this pull request
feat: add batching functionality for withdraw in YABTransfer #112
Closed
@taturosati taturosati requested a review from uri-99 March 19, 2024 16:06
@taturosati taturosati requested review from JuArce and rcatalan98 March 19, 2024 16:06
@taturosati taturosati changed the title feat: add batching functionality for claim payment feat (starknet): add batching functionality for claim_payment Mar 22, 2024
@taturosati taturosati marked this pull request as ready for review March 22, 2024 21:02
uri-99
uri-99 requested changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚧

contracts/ethereum/script/Deploy.s.sol Show resolved Hide resolved
contracts/ethereum/set_starknet_claim_payment_selector.sh Outdated Show resolved Hide resolved
contracts/starknet/.env.example Show resolved Hide resolved
contracts/ethereum/test/ACL.t.sol Show resolved Hide resolved
contracts/ethereum/test/Transfer_Claim_SN.t.sol Show resolved Hide resolved
contracts/starknet/src/tests/test_escrow_claim.cairo Show resolved Hide resolved
contracts/starknet/src/escrow.cairo Show resolved Hide resolved
contracts/starknet/src/escrow.cairo Show resolved Hide resolved
contracts/ethereum/src/PaymentRegistry.sol Outdated Show resolved Hide resolved
contracts/ethereum/src/PaymentRegistry.sol Show resolved Hide resolved
@taturosati taturosati changed the base branch from main to develop March 26, 2024 12:51
@taturosati taturosati mentioned this pull request Mar 26, 2024
Merged
JuArce
JuArce reviewed Mar 27, 2024
View reviewed changes
contracts/ethereum/src/PaymentRegistry.sol Outdated Show resolved Hide resolved
contracts/starknet/src/escrow.cairo Show resolved Hide resolved
contracts/starknet/src/tests/test_escrow_claim.cairo Outdated Show resolved Hide resolved
contracts/starknet/src/tests/test_escrow_claim.cairo Outdated Show resolved Hide resolved
contracts/starknet/src/tests/test_escrow_claim.cairo Outdated Show resolved Hide resolved
@taturosati taturosati merged commit 529c248 into develop Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-99 uri-99 uri-99 requested changes

@JuArce JuArce JuArce approved these changes

@rcatalan98 rcatalan98 Awaiting requested review from rcatalan98

Assignees

@taturosati taturosati

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add batching functionality for withdraw in YABTransfer
3 participants
@taturosati @uri-99 @JuArce