-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (zksync): add batching functionality for claim payment #198
Merged
JuArce
merged 13 commits into
develop
from
187-feat-zksync-add-batching-functionality-for-claim_payment-in-paymentregistry
Apr 3, 2024
Merged
feat (zksync): add batching functionality for claim payment #198
JuArce
merged 13 commits into
develop
from
187-feat-zksync-add-batching-functionality-for-claim_payment-in-paymentregistry
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hdraw-in-yabtransfer'
…ty-for-claim_payment-in-paymentregistry'
Before merging, this pr should implement breaking changes from #183 |
…ty-for-claim_payment-in-paymentregistry'
JuArce
approved these changes
Apr 3, 2024
JuArce
deleted the
187-feat-zksync-add-batching-functionality-for-claim_payment-in-paymentregistry
branch
April 3, 2024 18:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batching claim_payment for ZKSync for gas savings
claim_payment_batch
on ZKSync escrow contract. This function acts the same asclaim_payment
but takes in N orders instead of just one.claimPaymentBatchZKSync
onPaymentRegistry.sol
. This function acts the same asclaimPaymentZKSync
but takes N orders instead of just one.