Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (zksync): add batching functionality for claim payment #198

Conversation

taturosati
Copy link
Contributor

@taturosati taturosati commented Mar 26, 2024

Batching claim_payment for ZKSync for gas savings

  • Creates a new function claim_payment_batch on ZKSync escrow contract. This function acts the same as claim_payment but takes in N orders instead of just one.
  • Creates a new function claimPaymentBatchZKSync on PaymentRegistry.sol. This function acts the same as claimPaymentZKSync but takes N orders instead of just one.

@taturosati taturosati marked this pull request as ready for review March 27, 2024 15:52
@taturosati taturosati requested review from uri-99 and JuArce March 27, 2024 15:52
@JuArce
Copy link
Collaborator

JuArce commented Apr 2, 2024

Before merging, this pr should implement breaking changes from #183

@JuArce JuArce merged commit 5ae6f6e into develop Apr 3, 2024
3 checks passed
@JuArce JuArce deleted the 187-feat-zksync-add-batching-functionality-for-claim_payment-in-paymentregistry branch April 3, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants