Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#413: Added additional constructors to HmRqHeader #440

Merged
merged 2 commits into from
Nov 16, 2015

Conversation

bdragan
Copy link
Contributor

@bdragan bdragan commented Nov 14, 2015

#413: Added additional constructors to HmRqHeader.

@davvd
Copy link

davvd commented Nov 15, 2015

@bdragan Thanks, someone will review your pull request soon

@davvd
Copy link

davvd commented Nov 15, 2015

@pinaf please review, thanks

break;
outer:
for (final String name : headers.names()) {
for (final String value: headers.header(name)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdragan let's add

if (result) {
    break;
}

@pinaf
Copy link

pinaf commented Nov 16, 2015

@bdragan nice job

@pinaf
Copy link

pinaf commented Nov 16, 2015

@bdragan 10 comments

@bdragan
Copy link
Contributor Author

bdragan commented Nov 16, 2015

@pinaf Thanks. Please take a look at the new commit.

@pinaf
Copy link

pinaf commented Nov 16, 2015

@rultor merge

@pinaf
Copy link

pinaf commented Nov 16, 2015

@bdragan thanks!

@rultor
Copy link
Collaborator

rultor commented Nov 16, 2015

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Owner

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented Nov 16, 2015

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1a5baff into yegor256:master Nov 16, 2015
@rultor
Copy link
Collaborator

rultor commented Nov 16, 2015

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@davvd
Copy link

davvd commented Nov 18, 2015

@elenavolokhova please, review this issue for QA compliance, as per par.24

@davvd
Copy link

davvd commented Nov 18, 2015

@rultor deploy pls

@rultor
Copy link
Collaborator

rultor commented Nov 18, 2015

@rultor deploy pls

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Nov 18, 2015

@rultor deploy pls

@davvd Done! FYI, the full log is here (took me 13min)

@elenavolokhova
Copy link

@davvd Quality is good here.

@davvd
Copy link

davvd commented Nov 19, 2015

@davvd Quality is good here.

@elenavolokhova thank you, good quality is always good ;)

@davvd
Copy link

davvd commented Nov 19, 2015

@pinaf just added 10 mins to @elenavolokhova (for QA), payment ID is 70104518. Thanks for your contribution, 29 mins was added to your account, payment ID is AP-70323889J3006360N, 47 hours and 5 mins spent total. extra minutes for review comments (c=14). +29 added to your rating, at the moment it is: +4326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants