Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HmRqHeader.java:45-52: Implement additional constructors. According to... #413

Closed
davvd opened this issue Oct 22, 2015 · 15 comments
Closed

Comments

@davvd
Copy link

davvd commented Oct 22, 2015

Puzzle 260-de67913e in src/main/java/org/takes/facets/hamcrest/HmRqHeader.java:45-52 has to be resolved: Implement additional constructors. According to #260 there should be also available such constructors: public HmRsHeader(final Matcher

? extends Map.Entry

mtchr); public HmRsHeader(final String header, final Matcher

? extends Iterable

mtchr); public HmRsHeader(final String header, final Matcher

? extends String

mtchr); public HmRsHeader(final String header, final String value);... The puzzle was created by Eugene Kondrashev on 1-Oct-2015.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Author

davvd commented Oct 22, 2015

@yegor256 since there is no milestone yet I set it to "1.0"

@davvd davvd added this to the 1.0 milestone Oct 22, 2015
@davvd
Copy link
Author

davvd commented Oct 31, 2015

@prondzyn the task is yours please proceed

@prondzyn
Copy link
Contributor

@davvd I started work on the task, but there were some inconsistencies so I asked about resolving them in 260#issuecomment-152758204. I'm blocked and waiting on the decision.

@davvd
Copy link
Author

davvd commented Nov 1, 2015

@davvd I started work on the task, but there were some inconsistencies so I asked about resolving them in 260#issuecomment-152758204. I'm blocked and waiting on the decision.

@prondzyn sure, let's wait for #260

@prondzyn
Copy link
Contributor

prondzyn commented Nov 9, 2015

@davvd please find someone else. Thanks.

@davvd
Copy link
Author

davvd commented Nov 11, 2015

@davvd please find someone else. Thanks.

@prondzyn I deducted 30 points from your rating

@davvd
Copy link
Author

davvd commented Nov 11, 2015

@davvd please find someone else. Thanks.

@prondzyn right, I will find someone else, no problem

@davvd davvd removed the @prondzyn label Nov 11, 2015
@davvd
Copy link
Author

davvd commented Nov 13, 2015

@bdragan please proceed, it's yours

@bdragan
Copy link
Contributor

bdragan commented Nov 16, 2015

@davvd PR #440 has been merged.

@davvd
Copy link
Author

davvd commented Nov 17, 2015

@davvd PR #440 has been merged.

@bdragan thanks

@davvd
Copy link
Author

davvd commented Nov 19, 2015

@yegor256 Thanks, closing it now.

@davvd davvd closed this as completed Nov 19, 2015
@davvd
Copy link
Author

davvd commented Nov 19, 2015

@ypshenychka please, review this issue for QA compliance, as per par.24

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented Nov 21, 2015

@davvd Quality is good.

@ypshenychka thanks for the review

@davvd
Copy link
Author

davvd commented Nov 21, 2015

@bdragan added 10 mins to @ypshenychka, for QA review, payment code is 70171877

I just added 30 mins to your account, many thanks for your contribution (70171882).. 117 hours and 33 mins spent here

+30 added to your rating, current score is: +391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants