-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#412: Added additional constructors to HmRsHeader #434
Conversation
@bdragan Thanks for the pull request, let me find a reviewer.. |
@pinaf it's yours, please review |
* | ||
* @author Dragan Bozanovic ([email protected]) | ||
* @version $Id$ | ||
* @since 0.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdragan 0.27 I believe
@bdragan nice. 4 comments. |
@pinaf Thanks, please see my remarks and the new commit. |
@rultor merge |
@bdragan thanks! |
@rultor merge |
@ypshenychka please, review this issue for QA compliance, as per par.24 |
@rultor deploy pls |
@pinaf
There were two design issues found during code review, and two cosmetic concerns. |
@ypshenychka I confirm |
@pinaf thanks |
@davvd Quality is acceptable. |
@ypshenychka thanks for the review, we'll try better next time |
@pinaf paied 10 mins to @ypshenychka for QA review (payment ID is |
#412: Added additional constructors to HmRsHeader.