Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HmRsHeader.java:46-53: Implement additional constructors. According to... #412

Closed
davvd opened this issue Oct 22, 2015 · 9 comments
Closed

Comments

@davvd
Copy link

davvd commented Oct 22, 2015

Puzzle 260-1c71c6a2 in src/main/java/org/takes/facets/hamcrest/HmRsHeader.java:46-53 has to be resolved: Implement additional constructors. According to #260 there should be also available such constructors public HmRsHeader(final Matcher

? extends Map.Entry

mtchr); public HmRsHeader(final String header, final Matcher

? extends Iterable

mtchr); public HmRsHeader(final String header, final Matcher

? extends String

mtchr); public HmRsHeader(final String header, final String value);... The puzzle was created by Eugene Kondrashev on 1-Oct-2015.

If you have any technical questions, don't ask me, submit new tickets instead

@davvd
Copy link
Author

davvd commented Oct 22, 2015

@yegor256 milestone set to 1.0 (correct me if I am wrong)

@davvd davvd added this to the 1.0 milestone Oct 22, 2015
@davvd
Copy link
Author

davvd commented Oct 30, 2015

@bdragan please go ahead with this task, it's yours

@bdragan
Copy link
Contributor

bdragan commented Nov 10, 2015

@davvd PR #434 has been merged.

@davvd
Copy link
Author

davvd commented Nov 12, 2015

@davvd PR #434 has been merged.

@bdragan thanks

@davvd
Copy link
Author

davvd commented Nov 14, 2015

@yegor256 It is closed now

@davvd davvd closed this as completed Nov 14, 2015
@davvd
Copy link
Author

davvd commented Nov 14, 2015

@elenavolokhova please, review this ticket for compliance with our QA rules

@elenavolokhova
Copy link

@davvd Looks good!

@davvd
Copy link
Author

davvd commented Nov 15, 2015

@davvd Looks good!

@elenavolokhova thanks for the review and a good remark

@davvd
Copy link
Author

davvd commented Nov 15, 2015

@bdragan I added 10 mins to @elenavolokhova (for QA review) in transaction 69643156; Thank you, I have added 30 mins to your account in payment/transaction "69643161", time consumed: 334 hours and 6 mins; added +30 to your rating, now it is equal to +331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants