Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkProxy #377

Closed
pinaf opened this issue Aug 21, 2015 · 37 comments
Closed

TkProxy #377

pinaf opened this issue Aug 21, 2015 · 37 comments

Comments

@pinaf
Copy link

pinaf commented Aug 21, 2015

A decorator class TkProxy would be useful. It would pass along requests received in .act to a different destination (internally handling body, headers, etc for the new request) and also proxy back responses.


- ~~`377-e6ce369a`/#458~~ (by Sebin George) - `458-ca123cf9`/#656 (by Nicolas FILOTTO)
@pinaf
Copy link
Author

pinaf commented Aug 21, 2015

@yegor256 what do you think about this one?

@davvd
Copy link

davvd commented Aug 24, 2015

@yegor256 please dispatch this issue

@gvlasov
Copy link
Contributor

gvlasov commented Sep 12, 2015

@yegor256 I support the idea, too.

@yegor256 yegor256 added the bug label Sep 12, 2015
@yegor256
Copy link
Owner

@pinaf yeah, good idea, thanks

@davvd
Copy link

davvd commented Sep 12, 2015

@pinaf milestone set to 1.0 (correct me if I am wrong)

@davvd davvd added this to the 1.0 milestone Sep 12, 2015
@davvd
Copy link

davvd commented Sep 12, 2015

@pinaf thanks for this report, I added 15 mins to your account, in transaction AP-00L05667MK3382931

@davvd
Copy link

davvd commented Sep 17, 2015

@tiaped this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here; The budget of this task is 30 mins. This is exactly how much time will be compensated, when the task is completed. Read about our Definition of Done

@davvd davvd added the @tiaped label Sep 17, 2015
@tiaped
Copy link

tiaped commented Sep 18, 2015

Hi, I have no idea of what to put in

  • @Version $Id: 9357c24e802b82a9275a1f58d2ff0d2d4eb69397 $
  • @SInCE 0.20

Could please help?
Are you ok with abstract classes?
I think I will make preAct and postAct methods.

@tiaped
Copy link

tiaped commented Sep 18, 2015

@davvd I want also to be sure that the aim of the issue is to update request before acting and update reponse before returning.
Am I right?

@tiaped
Copy link

tiaped commented Sep 18, 2015

FYI I have some issues on qulice with maven 3.0.5. Everything was fine with maven 3.3.3.

@gvlasov
Copy link
Contributor

gvlasov commented Sep 18, 2015

@tiaped Qulice doesn't work with Maven older than 3.2.5. And please address all your comments. If you're not sure to whom you should address them, read the work policy.

$Id: 9357c24e802b82a9275a1f58d2ff0d2d4eb69397 $ is for https://stackoverflow.com/questions/384108/moving-from-cvs-to-git-id-equivalent. You basically don't touch it (it will be replaced with just $Id$ automatically by git) and put $Id$ in @version tags of your new classes.

@tiaped
Copy link

tiaped commented Sep 18, 2015

@Suseika Thanks a lot

@tiaped
Copy link

tiaped commented Sep 18, 2015

@davvd PR #377 is ready for review

@davvd
Copy link

davvd commented Sep 18, 2015

@davvd PR #377 is ready for review

@tiaped thanks, I'll take a look

@tiaped
Copy link

tiaped commented Sep 19, 2015

I have a question.
Is there a way to know the method of a request?
I think I can deal with other things.
I'll come back for other questions

@gvlasov
Copy link
Contributor

gvlasov commented Sep 19, 2015

@tiaped
Here is a decorator for obtaining a method:
https://github.com/yegor256/takes/blob/master/src/main/java/org/takes/rq/RqMethod.java
How it is supposed to be used:
http://www.yegor256.com/2015/02/26/composable-decorators.html

And I have to remind you again to address every single comment to someone, i.e. comments should start with @ username, that's our rule.

@tiaped
Copy link

tiaped commented Sep 20, 2015

@davvd please reassign the task.

I think that the issue is more complicated than expected.
I am going to use jcabi http request and response. But In my opinion, in order to handle every kind of requests (specificaly POST method with various ways of passing parameters or providing files) and handle every kind of responses (use the correct class to handle correctly (HTML, JSON, REST, others...) it could take some time.

@pinaf
Copy link
Author

pinaf commented Sep 20, 2015

@tiaped you don't have to handle each of those cases individually. All you have to do is pass along all headers and the body. That's all that exists in any HTTP message.

@davvd davvd removed the @tiaped label Sep 20, 2015
@davvd
Copy link

davvd commented Sep 21, 2015

@hs3180 this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here... Total fixed cost of this task is 30 mins (see this for more info)

@davvd davvd added the @hs3180 label Sep 21, 2015
@davvd
Copy link

davvd commented Oct 6, 2015

@hs3180 you're holding this ticket for 15 days already. If it is not finished (and closed) in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle (this article should help if you're stuck)

added -30 to your rating, now it is equal to -112

@davvd
Copy link

davvd commented Oct 13, 2015

@hs3180 it takes too long. Usually, we expect any task to be finished in less than a week. I'll assign someone else. Please stop working with it right now. See our no obligations principle. -60 added to your rating, current score is: -232

@davvd davvd removed the @hs3180 label Oct 14, 2015
@davvd
Copy link

davvd commented Oct 18, 2015

@bdragan could you please pick this up? This article explains how we work. Any technical questions you may ask right here. Task's budget is 30 mins (see this for explanation)

@davvd davvd added the @bdragan label Oct 18, 2015
@yegor256 yegor256 changed the title Proxy Takes TkProxy Oct 30, 2015
bdragan added a commit to bdragan/takes that referenced this issue Oct 30, 2015
bdragan added a commit to bdragan/takes that referenced this issue Oct 31, 2015
@bdragan
Copy link
Contributor

bdragan commented Nov 3, 2015

@davvd There was a slight misunderstanding about the requirements. Please approve a bit more time for this issue. Thank you!

@davvd
Copy link

davvd commented Nov 3, 2015

@davvd There was a slight misunderstanding about the requirements. Please approve a bit more time for this issue. Thank you!

@bdragan of course, thanks for letting me know, take your time

bdragan added a commit to bdragan/takes that referenced this issue Nov 4, 2015
bdragan added a commit to bdragan/takes that referenced this issue Nov 5, 2015
bdragan added a commit to bdragan/takes that referenced this issue Nov 6, 2015
bdragan added a commit to bdragan/takes that referenced this issue Nov 11, 2015
`Transfer-Encoding` headers before attempting to read the request body.
bdragan added a commit to bdragan/takes that referenced this issue Dec 7, 2015
@bdragan
Copy link
Contributor

bdragan commented Dec 8, 2015

@pinaf PR #421 has been merged. The issue can be closed.

@pinaf
Copy link
Author

pinaf commented Dec 8, 2015

@bdragan thanks!

@pinaf pinaf closed this as completed Dec 8, 2015
@yegor256
Copy link
Owner

yegor256 commented Dec 8, 2015

@rultor release, tag is 0.28

@rultor
Copy link
Collaborator

rultor commented Dec 8, 2015

@rultor release, tag is 0.28

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Dec 8, 2015

@rultor release, tag is 0.28

@yegor256 Done! FYI, the full log is here (took me 1hr)

@davvd
Copy link

davvd commented Dec 9, 2015

@pinaf once 377-e6ce369a/#458 puzzle is resolved (later, in another ticket), this ticket will be fully complete

@davvd
Copy link

davvd commented Dec 9, 2015

@ypshenychka please, review this task for compliance with our quality rules

@ypshenychka
Copy link

@tiaped
According to our QA Rules:

Messages in a ticket always start with a name of a user they are addressed to.

Please correct all your messages by indicating an addressee in the beginning.

@ypshenychka
Copy link

@tiaped ping

@ypshenychka
Copy link

@davvd Quality is acceptable.

@davvd
Copy link

davvd commented Jan 5, 2016

@davvd Quality is acceptable.

@ypshenychka thanks for the review, we'll try better next time

@davvd
Copy link

davvd commented Jan 5, 2016

@bdragan added 10 mins to @ypshenychka, for QA review, payment code is 73869743

I just added 30 mins to your account, many thanks for your contribution (73869763).. 1221 hours and 45 mins spent here

+30 added to your rating, current score is: +391

@davvd
Copy link

davvd commented May 30, 2016

@pinaf the last puzzle 458-ca123cf9/#656 originated from here solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants