Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkProxyTest.java:52-54: We need more tests for... #656

Closed
davvd opened this issue Mar 22, 2016 · 16 comments
Closed

TkProxyTest.java:52-54: We need more tests for... #656

davvd opened this issue Mar 22, 2016 · 16 comments

Comments

@davvd
Copy link

davvd commented Mar 22, 2016

Puzzle 458-ca123cf9 in src/test/java/org/takes/tk/TkProxyTest.java:52-54 has to be resolved: We need more tests for TkProxy. The tests should verify different combinations of request/response headers. This is the continuation of the issue #377.... The puzzle was created by Sebin George on 15-Mar-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Mar 22, 2016

@triberraar it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket

Task's budget is 30 mins (see this for explanation)

@davvd
Copy link
Author

davvd commented Mar 22, 2016

@yegor256 I set the milestone to 1.0 since there is nothing set yet

@davvd davvd added this to the 1.0 milestone Mar 22, 2016
@davvd
Copy link
Author

davvd commented Apr 6, 2016

@triberraar the task is your hands for the last 15 days.. keep in mind that if it's not closed in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle. This article should help if you're stuck

do not forget that you should remove the @todo puzzle from the source code

added -30 to your rating, now it is equal to -60

@davvd
Copy link
Author

davvd commented Apr 11, 2016

@triberraar it takes too long. Usually, we expect any task to be finished in less than a week. I'll assign someone else. Please stop working with it right now. See our no obligations principle. added -60 to your rating, now it is equal to -210

@davvd davvd removed the @triberraar label Apr 11, 2016
@davvd
Copy link
Author

davvd commented Apr 12, 2016

@essobedo it's yours, please go ahead

@essobedo
Copy link
Contributor

@davvd here is my PR #661 please find a reviewer

@davvd
Copy link
Author

davvd commented Apr 12, 2016

@davvd here is my PR #661 please find a reviewer

@essobedo OK, sure

@essobedo
Copy link
Contributor

@davvd the PR has been merged, it is ready for the QA

@essobedo
Copy link
Contributor

@davvd need more time for other tasks of the puzzle to comple

@davvd
Copy link
Author

davvd commented Apr 22, 2016

@davvd the PR has been merged, it is ready for the QA

@essobedo OK

@davvd
Copy link
Author

davvd commented Apr 22, 2016

@davvd need more time for other tasks of the puzzle to comple

@essobedo of course, thanks for letting me know, take your time

@davvd
Copy link
Author

davvd commented Apr 22, 2016

@ypshenychka please, review this task for compliance with our quality rules

@davvd
Copy link
Author

davvd commented Apr 22, 2016

@yegor256 The task is closed, thanks everybody

@davvd davvd closed this as completed Apr 22, 2016
@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented Apr 22, 2016

@davvd Quality is good.

@ypshenychka thanks a lot :)

@davvd
Copy link
Author

davvd commented Apr 22, 2016

@essobedo added 10 mins to @ypshenychka, for QA review, payment code is 84301631; I added 30 mins to your account, many thanks for working with the project (84301655)! The completion time here was 168 hours and 10 mins.; +30 added to your rating, current score is: +495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants