Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RqMultipart.Base incorrect handles non-printable ASCII characters #331

Closed
dmzaytsev opened this issue Jun 4, 2015 · 27 comments
Closed

RqMultipart.Base incorrect handles non-printable ASCII characters #331

dmzaytsev opened this issue Jun 4, 2015 · 27 comments
Labels
30 mins bug DEV @dmzaytsev urgent
Milestone
1.0

Comments

@dmzaytsev
Copy link
Contributor

RqMultipart.Base incorrect handles non-printable ASCII characters
to reproduce it just make a small changes in RqMultipartTest.handlesRequestInTime()
https://github.com/yegor256/takes/blob/master/src/test/java/org/takes/rq/RqMultipartTest.java#L357

change

for (int ind = 0; ind < length; ++ind) {
            bwr.write("X");
}

to

Random rnd = new Random();
for (int ind = 0; ind < length; ++ind) {
    bwr.write(String.format("%c", rnd.nextInt(128)));         
}

bwr.write(String.format("%c", rnd.nextInt(108)+20)); will work fine.
so problem in the non-printable characters from 0 to 19
@yegor256 yegor256 added the bug label Jun 4, 2015
@davvd
Copy link

davvd commented Jun 4, 2015

@dmzaytsev I will ask someone to take care of this task soon

@davvd
Copy link

davvd commented Jun 4, 2015

@dmzaytsev since the ticket has no milestone I set it to 1.0

@davvd davvd added this to the 1.0 milestone Jun 4, 2015
@davvd
Copy link

davvd commented Jun 4, 2015

@dmzaytsev many thanks for the bug report, I added 15 mins to your acc, transaction 58631336

@davvd
Copy link

davvd commented Jun 4, 2015

@lautarobock this task is yours, please help (see our key principles of work). If you have any technical questions, don't hesitate to ask right here... The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed

@dmzaytsev dmzaytsev mentioned this issue Jun 5, 2015
Closed
@dmzaytsev
Copy link
Contributor Author

@lautarobock It would better to create a new test for this issue. Also please add a hash calculation for input and output data and compare them.

@yegor256 yegor256 added the urgent label Jun 6, 2015
@dmzaytsev
Copy link
Contributor Author

@lautarobock any progress here ?

@yegor256
Copy link
Owner

yegor256 commented Jun 7, 2015

@dmzaytsev let me fix it myself, will be faster. assign it to me pls

@dmzaytsev
Copy link
Contributor Author

@davvd assign this ticket to @yegor256 please

yegor256 pushed a commit that referenced this issue Jun 7, 2015
#331 reproduced
36b63d4
yegor256 pushed a commit that referenced this issue Jun 7, 2015
#331 test disabled
6cab52e
@yegor256
Copy link
Owner

yegor256 commented Jun 7, 2015

@dmzaytsev maybe you can fix it? I have no idea why it's happening. I only managed to reproduce it in a test, just like you suggested: 36b63d4

@dmzaytsev
Copy link
Contributor Author

@yegor256 ok, I'll try, assign it to me pls

@yegor256
Copy link
Owner

yegor256 commented Jun 7, 2015

@davvd assign @dmzaytsev to this task pls

@davvd
Copy link

davvd commented Jun 7, 2015

@davvd assign @dmzaytsev to this task pls

@yegor256 of course! @dmzaytsev it's your ticket now, please go ahead

@yegor256
Copy link
Owner

yegor256 commented Jun 7, 2015

@dmzaytsev any luck?

@dmzaytsev
Copy link
Contributor Author

dmzaytsev commented Jun 8, 2015 via email

dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Jun 8, 2015
@dmzaytsev
yegor256#331 fixed bug
63edccc
@dmzaytsev dmzaytsev mentioned this issue Jun 8, 2015
Merged
@dmzaytsev
Copy link
Contributor Author

@davvd please see PR #335
@yegor256 fixed

dmzaytsev added a commit to dmzaytsev/takes that referenced this issue Jun 8, 2015
@dmzaytsev
yegor256#331 enabled the test
2343702
@yegor256
Copy link
Owner

yegor256 commented Jun 8, 2015

@rultor release, tag is 0.20.1

@rultor
Copy link
Collaborator

rultor commented Jun 8, 2015

@rultor release, tag is 0.20.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jun 8, 2015

@rultor release, tag is 0.20.1

@yegor256 Oops, I failed. You can see the full log here (spent 6min)

Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.takes.facets.auth.social.PsTwitterTest

Results :

Tests in error: 
  RqMultipartTest.handlesRequestInTime:359 » TestTimedOut test timed out after 1...
  RqMultipartTest.notDistortContent:430 » TestTimedOut test timed out after 1000...

Tests run: 227, Failures: 0, Errors: 2, Skipped: 4

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:21 min
[INFO] Finished at: 2015-06-08T05:54:12+00:00
[INFO] Final Memory: 31M/463M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project takes: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project takes: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:195)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:861)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:729)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

yegor256 pushed a commit that referenced this issue Jun 8, 2015
#331 polished and removed timeouts
51aa5b8
@yegor256
Copy link
Owner

yegor256 commented Jun 8, 2015

@rultor release, tag is 0.20.1

@rultor
Copy link
Collaborator

rultor commented Jun 8, 2015

@rultor release, tag is 0.20.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jun 8, 2015

@rultor release, tag is 0.20.1

@yegor256 Done! FYI, the full log is here (took me 8min)

@dmzaytsev
Copy link
Contributor Author

@davvd PR #335 fixed the issue, I'm closing the ticket

@yegor256
Copy link
Owner

yegor256 commented Jun 8, 2015

@dmzaytsev thanks!

@davvd
Copy link

davvd commented Jun 9, 2015

@elenavolokhova please, review this task for compliance with our quality rules

@elenavolokhova
Copy link

@davvd Quality is good here!

@davvd
Copy link

davvd commented Jun 10, 2015

@davvd Quality is good here!

@elenavolokhova thanks a lot :)

@davvd
Copy link

davvd commented Jun 10, 2015

@dmzaytsev just added 10 mins to @elenavolokhova (for QA), payment ID is 59023368

Thanks for your contribution, 1 hour was added to your account, payment ID is 59023379, 14 hours and 15 mins spent total

the bonus for fast delivery (m=855)

+60 added to your rating, at the moment it is: +2480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins bug DEV @dmzaytsev urgent
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
5 participants
@yegor256 @davvd @rultor @elenavolokhova @dmzaytsev