Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file integrity loss after upload #310

Closed
k0r opened this issue Jun 3, 2015 · 34 comments
Closed

file integrity loss after upload #310

k0r opened this issue Jun 3, 2015 · 34 comments
Assignees
Milestone

Comments

@k0r
Copy link
Member

k0r commented Jun 3, 2015

uploaded files loose integrity and become corrupted. to replicate, upload a file then download.

so far, here are the file types that are affected:

.mp4 [before | after]
file size: 9mb
after 15 seconds, the video isn't consistent with original.

.jpg [before | after]
file size: 24mb
jpeg image isn't consistent with original.

.bmp [before | after]
file size: 10mb
bitmap image isn't consistent with original.

.flac [before | after]
file size: 14mb
skipping throughout the track.

.psd
file size: 23mb
photoshop "could not complete your request" error.

.pdf
file size: 5mb
missing pages.

@k0r
Copy link
Member Author

k0r commented Jun 3, 2015

@yegor256 any ideas?

@k0r
Copy link
Member Author

k0r commented Jun 3, 2015

@dmzaytsev suggestions?

@dmzaytsev
Copy link
Contributor

@k0r it needs to be investigated... Is it reproduceble on the local instance?

@k0r
Copy link
Member Author

k0r commented Jun 3, 2015

@dmzaytsev let me know if it is.

@k0r
Copy link
Member Author

k0r commented Jun 4, 2015

@yegor256 system can't be used until this is fixed. this ticket should be prioritized.

@k0r
Copy link
Member Author

k0r commented Jun 4, 2015

@yegor256 thanks.

@karato
Copy link

karato commented Jun 4, 2015

@k0r I set milestone here to 0.4, let me know if it is wrong

@karato karato added this to the 0.4 milestone Jun 4, 2015
@karato
Copy link

karato commented Jun 4, 2015

@dmzaytsev do this task, 30 mins is budget

@k0r
Copy link
Member Author

k0r commented Jun 4, 2015

@yegor256 updated.

@yegor256
Copy link
Contributor

yegor256 commented Jun 4, 2015

@dmzaytsev I suspect it's an issue with UTF-8 encoding...

@dmzaytsev
Copy link
Contributor

@yegor256 I'm not sure

@k0r
Copy link
Member Author

k0r commented Jun 4, 2015

@yegor256 looking at this, there are inconsistencies with this ticket.

@dmzaytsev
Copy link
Contributor

@karato we are waiting yegor256/takes#331

@k0r
Copy link
Member Author

k0r commented Jun 5, 2015

@dmzaytsev not sure about the solution you've suggested. to fix this ticket, I'd prefer if the solution was thoroughly researched. this is the most important feature of the application.

@dmzaytsev
Copy link
Contributor

@k0r sure, I taken into account

@k0r
Copy link
Member Author

k0r commented Jun 5, 2015

@yegor256 any progress with this ticket?

@yegor256
Copy link
Contributor

yegor256 commented Jun 5, 2015

@k0r let's wait for the fix in Takes, hopefully it will solve the problem here too

@k0r
Copy link
Member Author

k0r commented Jun 5, 2015

@yegor256 thanks.

@yegor256
Copy link
Contributor

yegor256 commented Jun 8, 2015

@dmzaytsev takes 0.20.1 was released a few minutes ago, I think you can go ahead and try to solve the problem here

dmzaytsev added a commit to dmzaytsev/nerodesk that referenced this issue Jun 8, 2015
@dmzaytsev
Copy link
Contributor

@karato please see PR #316

dmzaytsev added a commit to dmzaytsev/nerodesk that referenced this issue Jun 8, 2015
@k0r
Copy link
Member Author

k0r commented Jun 8, 2015

@rultor hello

@rultor
Copy link
Contributor

rultor commented Jun 8, 2015

@rultor hello

@k0r Hi there! I understand a few simple commands: "merge", "deploy", etc. This page explains them briefly. Any questions or bug reports are welcome. Have fun :)

@k0r
Copy link
Member Author

k0r commented Jun 8, 2015

@rultor release, tag is 0.3.37

@rultor
Copy link
Contributor

rultor commented Jun 8, 2015

@rultor release, tag is 0.3.37

@k0r Thanks for your request. @yegor256 Please confirm this.

@karato
Copy link

karato commented Jun 8, 2015

@karato please see PR #316

@dmzaytsev thanks, will take a look

@yegor256
Copy link
Contributor

yegor256 commented Jun 8, 2015

@rultor release, tag is 0.3.37

@rultor
Copy link
Contributor

rultor commented Jun 8, 2015

@rultor release, tag is 0.3.37

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jun 8, 2015

@rultor release, tag is 0.3.37

@yegor256 Done! FYI, the full log is here (took me 7min)

@k0r
Copy link
Member Author

k0r commented Jun 8, 2015

@yegor256 @dmzaytsev thanks.

@k0r
Copy link
Member Author

k0r commented Jun 8, 2015

@yegor256 @dmzaytsev seems to have been fixed.

@dmzaytsev
Copy link
Contributor

@k0r PR #316 fixed this issue, please close the ticket, thank you

@dmzaytsev
Copy link
Contributor

@karato I need more time here

@karato
Copy link

karato commented Jun 10, 2015

@karato I need more time here

@dmzaytsev agreed, take your time

@k0r k0r closed this as completed Jun 10, 2015
@karato
Copy link

karato commented Jun 12, 2015

@dmzaytsev Thanks a lot, I just topped your account for 30 mins, transaction ID 59071226, total time was 166 hours... +30 to your rating, your total score is +2645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants