broken test org.takes.rq.RqMultipartTest.consumesHttpRequest #253

dmzaytsev · 2015-05-05T01:26:38Z

We have the broken test org.takes.rq.RqMultipartTest.consumesHttpRequest in the master branch

Running org.takes.rq.RqMultipartTest Tests run: 10, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.132 sec <<< FAILURE! - in org.takes.rq.RqMultipartTest consumesHttpRequest(org.takes.rq.RqMultipartTest) Time elapsed: 1.033 sec <<< ERROR! java.io.IOException: Failed POST request to http://localhost:34885/ at com.jcabi.http.request.JdkRequest$1.send(JdkRequest.java:124) at com.jcabi.http.request.BaseRequest.fetchResponse(BaseRequest.java:299) at com.jcabi.http.request.BaseRequest.fetch(BaseRequest.java:214) at org.takes.rq.RqMultipartTest$2.exec(RqMultipartTest.java:308) at org.takes.http.FtRemote.exec(FtRemote.java:118) at org.takes.rq.RqMultipartTest.consumesHttpRequest(RqMultipartTest.java:303) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:318) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Caused by: java.net.SocketException: Connection reset at java.net.SocketInputStream.read(SocketInputStream.java:196) at java.net.SocketInputStream.read(SocketInputStream.java:122) at java.io.BufferedInputStream.fill(BufferedInputStream.java:235) at java.io.BufferedInputStream.read1(BufferedInputStream.java:275) at java.io.BufferedInputStream.read(BufferedInputStream.java:334) at sun.net.www.MeteredStream.read(MeteredStream.java:134) at java.io.FilterInputStream.read(FilterInputStream.java:133) at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:3066) at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:3060) at com.jcabi.http.request.JdkRequest$1.body(JdkRequest.java:189) at com.jcabi.http.request.JdkRequest$1.send(JdkRequest.java:116)

The text was updated successfully, but these errors were encountered:

marcuss · 2015-05-05T01:33:35Z

@dmzaytsev I see the same thing in the merge of my pull request, a question @yegor256 this must be corrected before I can close my already merged pull request? or they are deal with as different issues?

super132 · 2015-05-05T02:15:26Z

@dmzaytsev I can see that the error is caused by SocketException that Connection reset. Is there something wrong with the container that rultor runs in? I see no problem running the same tests in Appveyor.

dmzaytsev · 2015-05-05T03:49:25Z

@M4Solutions This error is caused by changes in the master branch.
Just wait while the issue will be resolved

@super132 you see Appveyor's log before merge.
If you merge with master and run mvn clean install you will see the error locally

super132 · 2015-05-05T04:07:48Z

@dmzaytsev , is the build from the Appvegor also a log before merge? It shows that it is building from a commit in master branch and it was successful:

https://ci.appveyor.com/project/yegor256/takes/branch/master

yegor256 · 2015-05-05T04:17:51Z

@dmzaytsev I can't reproduce this problem locally :( running tests multiple times, still no error

yegor256 · 2015-05-05T04:17:58Z

@dmzaytsev can you reproduce it locally?

dmzaytsev · 2015-05-05T04:22:45Z

@yegor256 sure
I reproduced it locally
windows 7 64 bit

dmzaytsev · 2015-05-05T05:47:42Z

@yegor256 I can't reproduce the issue with another windows desktop.
seems the error depends on the jdk/os version.
I will get access to that desktop a few hours later

ikhvostenkov · 2015-05-05T08:49:59Z

@yegor256 @dmzaytsev I have this error randomly on linux64 with java 1.7

dmzaytsev · 2015-05-05T11:46:02Z

@yegor256 what version of JDK uses Rultor ?

yegor256 · 2015-05-05T18:23:49Z

@dmzaytsev it's 1.7. you can check it yourself, just install Docker locally and run:

docker run -i -t --rm yegor256/rultor /bin/bash

You will get into shell with exactly the same environment as we have in rultor builds.

dmzaytsev · 2015-05-05T18:25:12Z

@yegor256 the error is stable on my enviroment

java version "1.8.0_45"
Java(TM) SE Runtime Environment (build 1.8.0_45-b15)
Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)
Windows 7 64bit SP 1

I see two issues:

the regular expression ".*[^a-z]name=\"([^\"]+)\".*" (RqMultipart.java:109) doesn't extract f-1 from the string "Content-Disposition: form-data; name=\"f-1\""(RqMultipartTest.java:318)
if the name is not found so we have broken connection in FtRemote instead exception. I think it is a bug. You can easy reproduce it that way

public void consumesHttpRequest() throws IOException {
        final Take take = new Take() {
            @Override
            public Response act(final Request req) throws IOException {
                return new RsText(
                    new RqPrint(
                        new RqMultipart.Smart(
                            new RqMultipart.Base(req)
                        ).single("f2")
                    ).printBody()
                );
            }
        };
        new FtRemote(take).exec(
            // @checkstyle AnonInnerLengthCheck (50 lines)
            new FtRemote.Script() {
                @Override
                public void exec(final URI home) throws IOException {
                    new JdkRequest(home)
                        .method("POST")
                        .header(
                            "Content-Type",
                            "multipart/form-data; boundary=AaB0zz"
                        )
                        .body()
                        .set(
                            Joiner.on(RqMultipartTest.CRLF).join(
                                "--AaB0zz",
                                "Content-Disposition: form-data; name=\"f1\"",
                                "",
                                "my picture",
                                "--AaB0zz--"
                            )
                        )

yegor256 · 2015-05-05T18:26:41Z

@dmzaytsev many thanks!

yegor256 · 2015-05-06T01:34:16Z

@davvd this is urgent

super132 · 2015-05-06T04:31:29Z

@yegor256 , just an update to this issue. I found that PR #210 has been merged by Rultor successfully. Please check the log below:

http://www.rultor.com/t/3570-99185933

The merge was done 9 hours ago from the moment I post this comment. I believe we can retry the merge. Thanks.

davvd · 2015-05-06T10:44:36Z

@dmzaytsev I am aware of the task, give me some time to find a developer...

davvd · 2015-05-06T10:44:40Z

@dmzaytsev I added milestone 1.0 to this issue, let me know if there has to be something else

davvd · 2015-05-06T20:59:03Z

@davvd this is urgent

@yegor256 sure, thanks, I added "urgent" tag to it

davvd · 2015-05-09T11:03:57Z

@Bertram25 This task is yours, please go ahead keeping in mind this. If any questions, don't hesitate to ask right here. 30 mins is the budget of the task. This is exactly how much will be paid when the problem is solved (no matter how much time you will actually spend). See this for more information

davvd · 2015-05-09T13:03:11Z

@dmzaytsev thanks for reporting! I topped your account for 15 mins, transaction 56895756

davvd · 2015-05-16T09:22:01Z

@davvd we're waiting for #291 here

@yegor256 yes, waiting for #291

davvd · 2015-05-18T10:52:16Z

@louzar This task is yours, please go ahead keeping in mind this. If any questions, don't hesitate to ask right here; Budget here is 30 mins (keep this principle in mind)

davvd · 2015-05-23T18:17:47Z

@Komaz please go ahead with this task, it's yours

iinozemtsev · 2015-05-25T04:32:42Z

@davvd waiting for #291

davvd · 2015-05-25T10:06:01Z

@davvd waiting for #291

@Komaz OK, let's wait for #291

iinozemtsev · 2015-05-29T05:06:57Z

@dmzaytsev is it ok that this issue is not unassigned?

dmzaytsev · 2015-05-29T05:09:02Z

@Komaz I see the @komaz tag here
It means you assigned to this ticket

iinozemtsev · 2015-05-29T05:28:37Z

@dmzaytsev yeah, but this issue is blocked by #291, I thought such issues should be unassigned to avoid penalty, e.g. yegor256/netbout#602

dmzaytsev · 2015-05-29T05:38:01Z

@Komaz yegor256/netbout#602 is postponed

but @davvd wrote to you above

@Komaz OK, let's wait for #291

You shouldn't be fined, I hope :)

Anyway @yegor256 and @davvd to manage this project
Ask them if you not sure

yegor256 · 2015-06-01T20:38:53Z

@Komaz yes, everything is fine here, we're blocked by #291

Bertram25 · 2015-06-01T22:04:37Z

@Komaz FYI, issue #291 is now closed.
Best regards,

davvd · 2015-06-02T09:48:06Z

@dmzaytsev I think we can continue, impediment #291 is closed

dmzaytsev · 2015-06-02T10:05:39Z

@Komaz FYI

@dmzaytsev I think we can continue, impediment #291 is closed

iinozemtsev · 2015-06-04T18:03:41Z

@dmzaytsev fixed in #329

dmzaytsev · 2015-06-04T18:11:52Z

@Komaz thanks!

davvd · 2015-06-05T20:56:28Z

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

ypshenychka · 2015-06-06T19:46:31Z

@davvd Quality is good.

davvd · 2015-06-06T21:03:18Z

@davvd Quality is good.

@ypshenychka thanks for the review and a good remark

davvd · 2015-06-06T21:14:12Z

@Komaz just added 10 mins to @ypshenychka (for QA), payment ID is 58676446; Much obliged! I have added 38 mins to your account in payment "AP-5MH89111A09400627", 57 hours and 30 mins spent; the bonus for fast delivery (m=3450); added +38 to your rating, now it is equal to +458

asaen mentioned this issue May 5, 2015

#160 let's get rid of List.add() - Part 3 #234

Merged

yegor256 added the bug label May 5, 2015

This was referenced May 5, 2015

PsGithub is not tested #42

Closed

PsGithub.java:54-56: There is currently no unit... #243

Closed

davvd added this to the 1.0 milestone May 6, 2015

davvd added the urgent label May 6, 2015

yegor256 pushed a commit that referenced this issue May 6, 2015

#253 test skipped

77e785e

davvd added DEV @bertram25 30 mins labels May 9, 2015

davvd added @bertram25 and removed @bertram25 labels May 17, 2015

davvd added @louzar and removed bug @louzar labels May 18, 2015

davvd added the @komaz label May 23, 2015

iinozemtsev mentioned this issue Jun 3, 2015

#253 Enabled RqMultipartTest.consumesHttpRequest #329

Merged

dmzaytsev closed this as completed Jun 4, 2015

broken test org.takes.rq.RqMultipartTest.consumesHttpRequest #253

broken test org.takes.rq.RqMultipartTest.consumesHttpRequest #253

Comments

dmzaytsev commented May 5, 2015

marcuss commented May 5, 2015

super132 commented May 5, 2015

dmzaytsev commented May 5, 2015

super132 commented May 5, 2015

yegor256 commented May 5, 2015

yegor256 commented May 5, 2015

dmzaytsev commented May 5, 2015

dmzaytsev commented May 5, 2015

ikhvostenkov commented May 5, 2015

dmzaytsev commented May 5, 2015

yegor256 commented May 5, 2015

dmzaytsev commented May 5, 2015

yegor256 commented May 5, 2015

yegor256 commented May 6, 2015

super132 commented May 6, 2015

davvd commented May 6, 2015

davvd commented May 6, 2015

davvd commented May 6, 2015

davvd commented May 9, 2015

davvd commented May 9, 2015

davvd commented May 16, 2015

davvd commented May 18, 2015

davvd commented May 23, 2015

iinozemtsev commented May 25, 2015

davvd commented May 25, 2015

iinozemtsev commented May 29, 2015

dmzaytsev commented May 29, 2015

iinozemtsev commented May 29, 2015

dmzaytsev commented May 29, 2015

yegor256 commented Jun 1, 2015

Bertram25 commented Jun 1, 2015

davvd commented Jun 2, 2015

dmzaytsev commented Jun 2, 2015

iinozemtsev commented Jun 4, 2015

dmzaytsev commented Jun 4, 2015

davvd commented Jun 5, 2015

ypshenychka commented Jun 6, 2015

davvd commented Jun 6, 2015

davvd commented Jun 6, 2015