PsGithub.java:54-56: There is currently no unit...

[davvd]

Puzzle 229-401562da in src/main/java/org/takes/facets/auth/social/PsGithub.java:54-56 has to be resolved: There is currently no unit test in PsGithubTest that checks that the request parameters are passed to the request body, instead of the URI. Let's add this test.... The puzzle was created by cyberone on 1-May-2015.

If you have any technical questions, don't ask me, submit new tickets instead

[davvd]

@dmzaytsev the task is yours,please go ahead

[dmzaytsev]

@davvd I will resolve the puzzle in the PR #228

[davvd]

@yegor256 since there is no milestone yet I set it to "1.0"

[dmzaytsev]

@davvd we are wating for #253 here

[yegor256]

@davvd waiting for #253

[dmzaytsev]

@davvd #228 has been merged. Please close the task

[davvd]

@davvd waiting for #253

@yegor256 right, let's wait for #253

[dmzaytsev]

@davvd you can see pull request #228 that is fixing this issue, if that's all here please close.

[dmzaytsev]

@davvd please close the task

[davvd]

@yegor256 Closing..

[davvd]

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

[elenavolokhova]

@davvd Quality is good.

[davvd]

@davvd Quality is good.

@elenavolokhova many thanks

[davvd]

@dmzaytsev just added 10 mins to @elenavolokhova (for QA), payment ID is 57168002. thank you, added 30 mins to your acc, payment num is 57168022, 169 hours and 42 mins spent in total to complete. +30 to your rating, your total score is +1460