Rejected #333
Merged
Rejected #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Constant length warning / message: Inform the user for categorials with constant length - Variables with constant values are "ignored" (strikethrough and grey)
- Rejected variables can be disabled (no longer grey or strikethrough) - Warnings in the overview are automatically collapsed if over 20 item (configurable), can also be disabled completely by setting the limit to 0. (#281)
Reject const
Warning config
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 87.41% 87.48% +0.06%
==========================================
Files 84 86 +2
Lines 1851 2021 +170
==========================================
+ Hits 1618 1768 +150
- Misses 233 253 +20
Continue to review full report at Codecov.
|
- Warning types were not properly equality checked - Warning templates are now optional (jinja ignore missing) - Renumber the MessageType enum for compatibility with `UNIFORM`
chanedwin
pushed a commit
to chanedwin/pandas-profiling
that referenced
this pull request
Oct 11, 2020
Rejected and constant variable support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines PR #324 and PR #326. Solutions for issue #281 and #315.
Handling for constant (values, length) variables
Configuration for rejected variables and warnings
Reintroduce
ProfileReport.get_rejected_variables()