Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for rejected variables and warnings #326

Closed
wants to merge 7 commits into from

Conversation

sbrugman
Copy link
Collaborator

  • Rejected variables can be disabled (no longer grey or strikethrough)
  • Warnings in the overview are automatically collapsed if over 20 item (configurable), can also be disabled completely by setting the limit to 0.

(#281)

sbrugman and others added 3 commits January 14, 2020 01:17
- Constant length warning / message: Inform the user for categorials with constant length
- Variables with constant values are "ignored" (strikethrough and grey)
- Rejected variables can be disabled (no longer grey or strikethrough)
- Warnings in the overview are automatically collapsed if over 20 item (configurable), can also be disabled completely by setting the limit to 0.

(#281)
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #326 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files          84       84           
  Lines        1822     1822           
=======================================
  Hits         1599     1599           
  Misses        223      223
Flag Coverage Δ
#examples 0% <0%> (ø) ⬆️
#issue 80.81% <0%> (ø) ⬆️
#unit 85.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4f9ad...ddb8be7. Read the comment docs.

@sbrugman sbrugman mentioned this pull request Jan 14, 2020
@sbrugman sbrugman closed this Jan 14, 2020
@sbrugman sbrugman deleted the warning-config branch February 11, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant