fix(resolver): Only optimize patterns in flat mode #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Fixes #4550. The optimization introduced in #4488 should only apply to flat installations since even if a single pattern can satisfy all resolved versions, it is not guaranteed that it is strict enough for resolving correctly for all patterns under all circumstances. **Test plan** Manual verification.
|
I'm not happy that we don't have a test case for this but I have tried so hard to create a minimal test case and I've failed. I also couldn't get tests work properly with the provided package.json file or even a reduced version of it. I think it is a combination of too many dependencies and our ad-hoc request cache so we need to look into that later. |
arcanis
approved these changes
Oct 3, 2017
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
**Summary** Fixes yarnpkg#4550. The optimization introduced in yarnpkg#4488 should only apply to flat installations since even if a single pattern can satisfy all resolved versions, it is not guaranteed that it is strict enough for resolving correctly for all patterns under all circumstances. **Test plan** Manual verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4550. The optimization introduced in #4488 should only
apply to flat installations since even if a single pattern can
satisfy all resolved versions, it is not guaranteed that it is
strict enough for resolving correctly for all patterns under all
circumstances.
Test plan
Manual verification.