Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't seem to install request@^2.82.0 and request-promise-native@^1.0.5 together #4550

Closed
graingert opened this issue Sep 26, 2017 · 4 comments · Fixed by #4613
Closed

can't seem to install request@^2.82.0 and request-promise-native@^1.0.5 together #4550

graingert opened this issue Sep 26, 2017 · 4 comments · Fixed by #4613

Comments

@graingert
Copy link
Contributor

graingert commented Sep 26, 2017

Do you want to request a feature or report a bug? bug

What is the current behavior?
Having an issue installing request@^2.82.0 I suspect it's to do with webdriverio pinning request@~2.81.0

If the current behavior is a bug, please provide the steps to reproduce.

https://github.com/graingert/yarn-request-strange
(remove the yarn.lock file, and run yarn install)

request is still outdated, and I get a peerdep warning on install.

What is the expected behavior?
request is updated, and no peerdep warning, webdriverio gets a nested request@~2.81.0

Please mention your node.js, yarn and operating system version.
node: v8.5.0
uname -a: Linux fester 4.13.0-11-generic #12-Ubuntu SMP Tue Sep 12 16:03:57 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
lsb_release -a: No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu Artful Aardvark (development branch)
Release: 17.10
Codename: artful
yarn: 1.1.0

@graingert
Copy link
Contributor Author

I suspect this will go away when webdriverio/webdriverio#2318 and Medium/phantomjs#742 are merged. But I'd like to know what's up.

@BYK
Copy link
Member

BYK commented Sep 27, 2017

Which Yarn version are you using?

@graingert
Copy link
Contributor Author

@BYK 1.1.0

@viatsko
Copy link
Contributor

viatsko commented Oct 1, 2017

Looks like it caused by 4020ccd, #4559 had a fix attempt, master (and v1.1.0) are still broken.

#4562 didn't fix this issue

BYK added a commit that referenced this issue Oct 3, 2017
**Summary**

Fixes #4550. The optimization introduced in #4488 should only
apply to flat installations since even if a single pattern can
satisfy all resolved versions, it is not guaranteed that it is
strict enough for resolving correctly for all patterns under all
circumstances.

**Test plan**

Manual verification.
arcanis pushed a commit that referenced this issue Oct 3, 2017
**Summary**

Fixes #4550. The optimization introduced in #4488 should only
apply to flat installations since even if a single pattern can
satisfy all resolved versions, it is not guaranteed that it is
strict enough for resolving correctly for all patterns under all
circumstances.

**Test plan**

Manual verification.
joaolucasl pushed a commit to joaolucasl/yarn that referenced this issue Oct 27, 2017
**Summary**

Fixes yarnpkg#4550. The optimization introduced in yarnpkg#4488 should only
apply to flat installations since even if a single pattern can
satisfy all resolved versions, it is not guaranteed that it is
strict enough for resolving correctly for all patterns under all
circumstances.

**Test plan**

Manual verification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants