Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Resolve peerDependencies from all higher levels, not just root #4478

Merged
merged 11 commits into from
Sep 16, 2017
Merged

Fix: Resolve peerDependencies from all higher levels, not just root #4478

merged 11 commits into from
Sep 16, 2017

Commits on Sep 15, 2017

  1. Fix: Resolve peerDependencies from all higher levels, not just root 

    **Summary**

Fixes #4446, fixes #4433. Follow up to #3893. The fix in #3893 was
too aggressive, allowing only top-level dependencies to be used in
peer dependency resolution which was incorrect. This patch allows
resolving peer dependencies from the same or higher levels in the
dependency tree.

**Test plan**

Additional unit and integration tests.
    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    a1ab4b3 View commit details
    Browse the repository at this point in the history

  2. Revert unnecessary semver upgrade

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    e79d0f4 View commit details
    Browse the repository at this point in the history

  3. Always select the closest peer dependency

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    e04d5d0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-peer-warnings

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    bd77957 View commit details
    Browse the repository at this point in the history

  5. even simpler code

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    86a3d26 View commit details
    Browse the repository at this point in the history

  6. Add integration test

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    dd3a380 View commit details
    Browse the repository at this point in the history

  7. Add simpler unit test

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    c384f4b View commit details
    Browse the repository at this point in the history

  8. Fix lint & moar concurrency

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    73ab3fd View commit details
    Browse the repository at this point in the history

  9. Fix react-scripts version in tests

    @BYK
    BYK committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    a443166 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2017

  1. Disable react-scripts test on Node 4

    @BYK
    BYK committed Sep 16, 2017
    Configuration menu
    Copy the full SHA
    fc87e2b View commit details
    Browse the repository at this point in the history

  2. Increase timeout interval for integration tests

    @BYK
    BYK committed Sep 16, 2017
    Configuration menu
    Copy the full SHA
    08b1a4f View commit details
    Browse the repository at this point in the history