Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for yarn owner #3893

Open
voxsim opened this issue Jul 10, 2017 · 5 comments
Open

Add tests for yarn owner #3893

voxsim opened this issue Jul 10, 2017 · 5 comments
Labels
cat-chore help wanted

Comments

@voxsim
Copy link
Contributor

voxsim commented Jul 10, 2017 •
edited
Loading

yarn owner has not tests at all and we should at least cover:

  • add
  • rm
  • list/ls
@voxsim voxsim changed the title Add tests for yarn check Add tests for yarn owner Jul 10, 2017
@peterschussheim
Copy link

@voxsim Can I take this one?

@voxsim
Copy link
Contributor Author

voxsim commented Jul 17, 2017

@peterschussheim yep go ahead!

@peterschussheim
Copy link

Great! Are there any examples you know would be a good starting point?

@voxsim
Copy link
Contributor Author

voxsim commented Jul 18, 2017

@peterschussheim nope, you can take inspiration from the other tests in the test forlder (for example https://github.com/yarnpkg/yarn/blob/master/__tests__/commands/licenses.js)

BYK added a commit that referenced this issue Sep 15, 2017
@BYK
Fix: Resolve peerDependencies from all higher levels, not just root
a1ab4b3 
**Summary**

Fixes #4446, fixes #4433. Follow up to #3893. The fix in #3893 was
too aggressive, allowing only top-level dependencies to be used in
peer dependency resolution which was incorrect. This patch allows
resolving peer dependencies from the same or higher levels in the
dependency tree.

**Test plan**

Additional unit and integration tests.
@BYK BYK mentioned this issue Sep 15, 2017
Merged
BYK added a commit that referenced this issue Sep 16, 2017
@BYK
Fix: Resolve peerDependencies from all higher levels, not just root (#…
96c215c 
…4478)

**Summary**

Fixes #4446, fixes #4433, fixes #2688, fixes #2387. Follow up to #3803. The fix in #3893 was
too aggressive, allowing only top-level dependencies to be used in
peer dependency resolution which was incorrect. This patch allows
resolving peer dependencies from the same or higher levels in the
dependency tree.

**Test plan**

Additional unit and integration tests.
joaolucasl pushed a commit to joaolucasl/yarn that referenced this issue Oct 27, 2017
@BYK @joaolucasl
Fix: Resolve peerDependencies from all higher levels, not just root (y…
9f1b692 
…arnpkg#4478)

**Summary**

Fixes yarnpkg#4446, fixes yarnpkg#4433, fixes yarnpkg#2688, fixes yarnpkg#2387. Follow up to yarnpkg#3803. The fix in yarnpkg#3893 was
too aggressive, allowing only top-level dependencies to be used in
peer dependency resolution which was incorrect. This patch allows
resolving peer dependencies from the same or higher levels in the
dependency tree.

**Test plan**

Additional unit and integration tests.
@rubycut
Copy link
Contributor

rubycut commented Mar 11, 2018 •
edited
Loading

@BYK , owner command seems to be broken, it doesn't return anything. I am trying to fix it, but I am now getting 1 maintainer @Daniel15 , but if I try to run npm owner list yarn, I get six maintainers., so which of these responses are correct?

@rubycut rubycut mentioned this issue Mar 28, 2018
Merged
BYK pushed a commit that referenced this issue Apr 13, 2018
@rubycut @BYK
fix(owner): Fix the currently broken yarn owner command (#5593)
8a7ee77 
**Summary**

* fixing currently broken owner command
* doesn't ask for npm username and password for list command
* adding basic test #3893 

**Test plan**

Yarn now correctly displays the list of package owners. Also added automated tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat-chore help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BYK @voxsim @rubycut @peterschussheim