Fix which check during yarn install (#2061)
#2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Also |
|
@torifat That's what I thought as well. Thanks for merging! |
|
This file isn't used any more (seems like I forgot to merge #2066). You'll have to change the file over here: https://github.com/yarnpkg/website/blob/master/install.sh |
Daniel15
pushed a commit
to yarnpkg/website
that referenced
this pull request
Dec 9, 2016
lovelypuppy0607
added a commit
to lovelypuppy0607/website
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2061. Since the
ifconstruct by design tests the exit value of commands, it’s better to test thewhich yarncommand directly.Test plan