Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script fails if ~/.yarn exists but does not contain a Yarn installation #2061

Closed
Daniel15 opened this issue Nov 28, 2016 · 1 comment · Fixed by #2071
Closed
Labels

Comments

@Daniel15
Copy link
Member

Daniel15 commented Nov 28, 2016

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
The installation script fails if ~/.yarn exists but does not contain a Yarn installation.

If the current behavior is a bug, please provide the steps to reproduce.

rm -rf ~/.yarn
mkdir ~/.yarn
curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 0.17.9

Results in:

Installing Yarn!
./install.sh: line 164: yarn: command not found

What is the expected behavior?
Installation script should work and install Yarn

@petebacondarwin
Copy link

It seems to me that this check:

if [ -n `which yarn` ]; then

is not failing as expected since which yarn is returning something that is not-null even if there is no yarn in the current path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants