Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for command "run" #1540

Closed
wants to merge 3 commits into from
Closed

Add tests for command "run" #1540

wants to merge 3 commits into from

Conversation

AlicanC
Copy link
Contributor

@AlicanC AlicanC commented Oct 28, 2016

See #821

@AlicanC
Copy link
Contributor Author

AlicanC commented Oct 28, 2016

@bestander tests are still failing on AppVeyor and Travis. TBH, I don't know what's going on. yarn/npm test works fine on my local.

I will come back and fix if I somehow figure out what's going on, but I'm stuck ATM.

@bestander
Copy link
Member

Appveyor can be flaky at times.
But in this situation both Travis and Appveyor fail with the new run tests.
Could it be OS specific?
Circle runs on Linux

@wyze wyze force-pushed the alicanc-run-tests branch from 46cd7b5 to c13eda6 Compare November 7, 2016 18:07
@wyze
Copy link
Member

wyze commented Nov 7, 2016

@AlicanC I just pulled this down and all the tests failed for me locally. I did rebase and push up to get it to run on CI, and it fails there as well. I suspect something isn't being mocked correctly.

@wyze
Copy link
Member

wyze commented Nov 14, 2016

Made redundant by #1788.

@wyze wyze closed this Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlicanC @bestander @wyze