Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional emoji support #960

Closed
daltones opened this issue Oct 13, 2016 · 31 comments
Closed

Optional emoji support #960

daltones opened this issue Oct 13, 2016 · 31 comments

Comments

@daltones
Copy link

Do you want to request a feature or report a bug?
Feature (maybe a bug, once one of the features in README is β€œMore emojis. πŸˆβ€ 😸)

What is the current behavior?
Emojis only for OSX

What is the expected behavior?
Emojis for other platforms

Please mention your node.js, yarn and operating system version.
node.js: v6.7.0
yarn: v0.15.1
OS: Arch Linux

This is sort of related to #405 and 9f58576.

As discussed in #405, emojis on Powershell are bad. But it could be good someplace else…

I tried to force enable emojis here (Gnome Terminal on Arch Linux) and worked very well (although limited to monochrome). That's because I have the properly font and configuration.

captura de tela de 2016-10-13 02-16-05

So it would be nicer if we could optionally enable emojis. It could be even an environment variable YARN_EMOJIS=1.

@GRiMe2D
Copy link

GRiMe2D commented Oct 13, 2016

Subjective opinion

Emojis aren't meant to be used in professional development tools. Not all people like emojis. And I'm sure not only I am here, who dislikes image usages on CLI interface.

However, if this tool can handler emojis well, it should be optionally enabled (or disabled).

@daltones
Copy link
Author

@Grim2d yeah, your β€œ(or disabled)” is implicitly inside my proposal of optional emojis.

I was testing yarn today and I was curious why my outputs didn't have emojis (as the documentation did). Then checking the code I found this:

emoji: process.stdout.isTTY && process.platform === 'darwin'

That's a weird imposition. The issue isn't just a opinion about emojis.

@patrys
Copy link

patrys commented Oct 13, 2016

@Grim2d In this context emoji are used as equivalents of icons that your usual GUI would have. Just because the Unicode spec calls them emoji does not automatically make them unprofessional.

@GRiMe2D
Copy link

GRiMe2D commented Oct 13, 2016

@patrys

emoji does not automatically make them unprofessional

But, emojis are widely used while chatting. Also I do. And I'm not saying that using emojis make tools unprofessional. I meant CLI is mostly text-based. And mostly uses English as primary language. Even being Russian native-speaker, seeing cyrillic chars on my terminal is not comfortable for me. Same goes emojis.

At last, supporting emojis only on some platforms is bad idea. While macOS (formerly OS X) fully supports emojis, how about other platforms?
And then there is a big issue with emojis - everyone interprets emojis differently. It affects designers, who draw every emoji. Just google "Same emoji different phone"

@patrys
Copy link

patrys commented Oct 13, 2016

everyone interprets emojis differently

Keep in mind we're talking about glyphs such as "magnifying glass" not "slightly frowning fisherman wearing a clown suit".

@mazameli
Copy link

Begun, the Emoji War, has.

@ifzm
Copy link

ifzm commented Oct 16, 2016

I think I need to support Windows. But support is not good

@z11h
Copy link

z11h commented Oct 16, 2016

Is there a way for chalk to render in the emojis being used along with the strings? Im not how it works.

/CC @sindresorhus

@sebmck
Copy link
Contributor

sebmck commented Oct 16, 2016

Resolved by #922.

@sebmck sebmck closed this as completed Oct 16, 2016
@ahmad2smile
Copy link

The pull request you mentioned isn't for windows support... It's for disabling Emojis... What are you doing..

@daltones
Copy link
Author

Yeah, #922 is not a solution for this issue. But maybe it's good for now. Yarn seems great but it has lots of important bugs to fix.

@ahmad2smile
Copy link

@daltones I understand that man ... I know its just a silly thing but He shouldn't have closed it without at least checking it first

@madrobby
Copy link

🍿

@luislobo
Copy link

@kittens It is not resolved by #922. That issue makes emojis optional. This issue actually is about bringing emojis to other platforms like Linux

@arutkowski00
Copy link

@kittens It is not resolved...

@tech4him1
Copy link

Why not just add an option?

@elyobo
Copy link
Contributor

elyobo commented Apr 12, 2017

#922 is not a fix for this (and saying that it is suggests that @kittens has misunderstood this issue). It is a useful fix (there are situations where you want to disable emojis), but this is about the opposite, situations where we want to enable emojis where they're currently disabled.

I assume that support under other platforms is too difficult and they don't want to deal with the support issues that they'd have by enabling it (even behind something like a --emoji flag) for something that's a bit of a gimmick rather than a key feature. Which is fair enough, but just say it if that's the case :)

Edit: PR to support forcing emojis on via --emoji added in #3126,

@elyobo
Copy link
Contributor

elyobo commented May 12, 2017

Above PR has been merged, so --emoji is now in master for non-Mac users πŸŽ‰

@luislobo
Copy link

luislobo commented May 16, 2017

@elyobo thank you! btw, I tried it but for some reason on my terminal I don't see any Emoji (Not that it takes my sleep away...). may be @daltones can share what he did to make Emojis work on his setup?
I'm using Ubuntu + i3 + terminator

@ifzm
Copy link

ifzm commented May 17, 2017

@luislobo Hello, i encountered this problem, tried various methods, including the installation of color emoji font can not be achieved.
Can refer to http://www.omgubuntu.co.uk/2016/12/quickly-find-emoji-from-the-command-line
If you can succeed, hope to be able to share here :)

@elyobo
Copy link
Contributor

elyobo commented May 17, 2017

@luislobo I suspect not wanting to deal with Linux users' emoji issues is why they didn't originally support this... I have no idea why your emojis aren't working, but I'm on Ubuntu too and mine are fine (although not in colour).

Did you install it from github though? npm tells me the latest release was five days ago, my PR is from four days ago, so the npm version will not have emoji support on non-darwin yet.

Edit: @ifzm that emoj tool is nifty :D

$ emoj cat
🐱  🐈  😺  😻  😸  😼  😽

@ifzm
Copy link

ifzm commented May 17, 2017

@elyobo thanks )
I also encountered the same problem, can not show emoji on Linux, i would like to configure what or install special fonts?
OS:Ubuntu 16.04
Yarn:0.24.5

@daltones I hope you can share under the Linux emoji font and related configuration,thank you very much )

@elyobo
Copy link
Contributor

elyobo commented May 17, 2017 via email

@ifzm
Copy link

ifzm commented May 18, 2017

@elyobo Thank you for your answer )
I will find a good reason

@willnode
Copy link

@elyobo sorry if this has been discussed somewhere, but is there a way to always turn on emoji so that I don't have to type --emoji all the time?

@elyobo
Copy link
Contributor

elyobo commented Nov 21, 2017

@willnode you can put a --emoji true into your .yarnrc to set this as the default.

@willnode
Copy link

yarn config set -- --emoji true.

@elyobo It works! Thanks πŸ˜‰.

@R-A-S
Copy link

R-A-S commented Feb 22, 2019

yarn config set -- --emoji false also works. Thanks!😌

@elyobo
Copy link
Contributor

elyobo commented Feb 22, 2019

Hey, hey, hey, why would you want to go and do that @R-A-S? :D

@R-A-S
Copy link

R-A-S commented Feb 22, 2019

Hey, hey, hey, why would you want to go and do that @R-A-S? :D

Just checked. And turned back "true" πŸ˜ƒ

@Usamaliaquat123
Copy link

yarn config set -- --emoji true its worked thanks boii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests