-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional emoji support #960
Comments
Subjective opinion Emojis aren't meant to be used in professional development tools. Not all people like emojis. And I'm sure not only I am here, who dislikes image usages on CLI interface. However, if this tool can handler emojis well, it should be optionally enabled (or disabled). |
@Grim2d yeah, your β(or disabled)β is implicitly inside my proposal of optional emojis. I was testing yarn today and I was curious why my outputs didn't have emojis (as the documentation did). Then checking the code I found this: emoji: process.stdout.isTTY && process.platform === 'darwin' That's a weird imposition. The issue isn't just a opinion about emojis. |
@Grim2d In this context emoji are used as equivalents of icons that your usual GUI would have. Just because the Unicode spec calls them emoji does not automatically make them unprofessional. |
But, emojis are widely used while chatting. Also I do. And I'm not saying that using emojis make tools unprofessional. I meant CLI is mostly text-based. And mostly uses English as primary language. Even being Russian native-speaker, seeing cyrillic chars on my terminal is not comfortable for me. Same goes emojis. At last, supporting emojis only on some platforms is bad idea. While macOS (formerly OS X) fully supports emojis, how about other platforms? |
Keep in mind we're talking about glyphs such as "magnifying glass" not "slightly frowning fisherman wearing a clown suit". |
Begun, the Emoji War, has. |
I think I need to support Windows. But support is not good |
Is there a way for chalk to render in the emojis being used along with the strings? Im not how it works. /CC @sindresorhus |
Resolved by #922. |
The pull request you mentioned isn't for windows support... It's for disabling Emojis... What are you doing.. |
Yeah, #922 is not a solution for this issue. But maybe it's good for now. Yarn seems great but it has lots of important bugs to fix. |
@daltones I understand that man ... I know its just a silly thing but He shouldn't have closed it without at least checking it first |
πΏ |
@kittens It is not resolved... |
Why not just add an option? |
#922 is not a fix for this (and saying that it is suggests that @kittens has misunderstood this issue). It is a useful fix (there are situations where you want to disable emojis), but this is about the opposite, situations where we want to enable emojis where they're currently disabled. I assume that support under other platforms is too difficult and they don't want to deal with the support issues that they'd have by enabling it (even behind something like a Edit: PR to support forcing emojis on via |
Above PR has been merged, so |
@luislobo Hello, i encountered this problem, tried various methods, including the installation of color emoji font can not be achieved. |
@luislobo I suspect not wanting to deal with Linux users' emoji issues is why they didn't originally support this... I have no idea why your emojis aren't working, but I'm on Ubuntu too and mine are fine (although not in colour). Did you install it from github though? npm tells me the latest release was five days ago, my PR is from four days ago, so the npm version will not have emoji support on non-darwin yet. Edit: @ifzm that emoj tool is nifty :D
|
I'm also on 16.04, didn't do anything in particular to set it up.
β¦On 17 May 2017 at 18:06, Jim ***@***.***> wrote:
@elyobo <https://github.com/elyobo> thanks )
I also encountered the same problem, can not show emoji on Linux, i would
like to configure what or install special fonts?
OSοΌUbuntu 16.04
@daltones <https://github.com/daltones> I hope you can share under the
Linux emoji font and related configurationοΌthank you very much )
β
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#960 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAY4_mSnnp4mbkUmLdWZBMxh1EDTNyEAks5r6qqYgaJpZM4KVfsG>
.
|
@elyobo Thank you for your answer ) |
@elyobo sorry if this has been discussed somewhere, but is there a way to always turn on emoji so that I don't have to type |
@elyobo It works! Thanks π. |
|
Hey, hey, hey, why would you want to go and do that @R-A-S? :D |
Just checked. And turned back "true" π |
yarn config set -- --emoji true its worked thanks boii |
Do you want to request a feature or report a bug?
Feature (maybe a bug, once one of the features in README is βMore emojis. πβ πΈ)
What is the current behavior?
Emojis only for OSX
What is the expected behavior?
Emojis for other platforms
Please mention your node.js, yarn and operating system version.
node.js: v6.7.0
yarn: v0.15.1
OS: Arch Linux
This is sort of related to #405 and 9f58576.
As discussed in #405, emojis on Powershell are bad. But it could be good someplace elseβ¦
I tried to force enable emojis here (Gnome Terminal on Arch Linux) and worked very well (although limited to monochrome). That's because I have the properly font and configuration.
So it would be nicer if we could optionally enable emojis. It could be even an environment variable
YARN_EMOJIS=1
.The text was updated successfully, but these errors were encountered: