-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable emojis if terminal isn't a TTY #405
Comments
We should likely disable them on Windows as well. |
If TTY is the standard way to check that's cool. I'd like to avoid straight platform sniff if possible so that it will light up when emoji support is added to Windows. It would also give Windows an indicator they could use to signal support. I think @sindresorhus has experience in this area. |
Can you provide your powershell script. |
It's shown in the screenshot - Literally just this:
|
Cool, here's my output: Here's a bit more on it sindresorhus/emoj#5. |
Ahh, I think I know what's up. I'm using Cmder rather than the default Windows terminal. It might use UTF-8 by default, or support Emoji while the default cmd.exe doesn't. |
Here's Cmder on my system: There's an open issue to support emojis in Cmder's dep Maximus5/ConEmu#554. |
I'm super confused as to how it's working in Cmder for me then! 😆 This is on my home PC, I'll try my work laptop later and see if it works there too. |
@kittens Is the platform sniff 💯 needed? |
@kittens What about Linux? I want the emoji there... |
On windows this should be definitely supported: |
@DRSDavidSoft Based on that thread, it sounds like Windows support isn't fully complete yet. |
@Daniel15 After eight years in 2024 we can finally (I hope) say that emojis can be used with a good terminal on Windows: Sidenote: In your original comment, Cmder is using ConEmu which is a great console emulator, albeit it displays emojis in that white color, still it's better than the old Of course, Windows Terminal + Cmder trumps all of them! |
No fun allowed.
The text was updated successfully, but these errors were encountered: