-
Notifications
You must be signed in to change notification settings - Fork 39
fixed issue regarding concurrent requests to dns #6
Conversation
Nice catch! |
CLA is valid! |
list.forEach(function (cb) { cb(err); }); | ||
delete callbackList[key]; | ||
} else { | ||
cache.set('lookup_' + domain + '_' + family, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the key
variable here too? If we change the way the key is constructed it'd be nice to only do it in one place.
Good stuff. When calling each callback ( |
You might want to add a warning comment where the If you change the pattern slightly, e.g to We used the same pattern for concurrent requests in a different project and only noticed when it crashed. |
You might also consider using the |
Any update on this? Is there a special reason why this PR was not merged? Is there anything one can do to help? |
@goloroden This PR has received a bunch of comments but hasn't been updated, so it appears to be abandoned. (As well there's a merge conflict which needs to be addressed.) If you (or anyone else) wish to submit a different PR which accomplishes the same thing we'd be happy to work to get it merged. |
Okay, thanks! |
@cloudrac3r Would you mind closing this PR now that #30 has landed (it still appears in the list of PRs I should know about, which is not needed 😉)? |
@goloroden Sorry, what do you want me to do? I am the author of 30, I am not the author of this one. |
No description provided.