Skip to content
This repository has been archived by the owner on Feb 13, 2021. It is now read-only.

Fix concurrent DNS requests #30

Merged
merged 8 commits into from
Mar 25, 2019
Merged

Fix concurrent DNS requests #30

merged 8 commits into from
Mar 25, 2019

Conversation

cloudrac3r
Copy link
Contributor

PR #6 was not merged due to not being updated as per the comments suggested, but I needed this feature, so I did it myself.

I believe I have successfully integrated esnunes's changes as well as addressing the comments raising in the previous pull request.

I have not tested this thoroughly, but it does appear to do what I need it to do: initiating 100 simultaneous requests to a website and analysing the traffic with Wireshark reveals only 2 DNS requests are made, one for the IPv4 address, one for the IPv6 address.

(cc @goloroden)

esnunes and others added 2 commits July 21, 2015 11:25
This patches dnscache with esnunes's concurrent request patch.
@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@cloudrac3r
Copy link
Contributor Author

Done.

@cloudrac3r
Copy link
Contributor Author

Work completed. Everything fixed. CLA signed. All tests pass.

Can this be merged in?

@WoZ
Copy link

WoZ commented Mar 25, 2019

@cloudrac3r

Hello! I've found that this module is unsupported and has some bugs. I may propose to use our module that was tested in production and highload environments. Also we have good unit and functional tests with 100% coverage, multi-records resolving and TTL support. Here it is: https://github.com/LCMApps/dns-lookup-cache

@sylvio sylvio merged commit 2d5aa0b into yahoo:master Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants