External serialization functions, plus moving of Lens functions #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolektiv
added a commit
that referenced
this pull request
Oct 9, 2015
External serialization functions, plus moving of Lens functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fantastic changes from @neoeinstein to allow passing in externally defined fromJson and toJson members for types that you don't control - makes it much simpler to write serialization code for System.* etc. types, or any other types where you can't write the serialization in the original type assembly.
Additionally, moved Json.setLens, etc. to Json.Lens.set, which is being harmonised across libraries which provide Aether lens functionality externally (generally monadic forms of the lens functions) - Freya is also moving to this. It also makes things consistent across libraries - Lens.set for core Aether lens functions, Json.Lens.set, Freya.Lens.set, etc. in external libraries which implement compatible functions. Non-breaking for now as shims are in place with deprecation - they will be removed in the next major version.