Add custom read write functions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged this in via a local pull, etc. Very cool! It'll be in 5.1.0 (#45) very shortly. There's some (currently non-breaking) changes to lens functions in there as well if you're using them - deprecations given though. Thanks for this, it's a very useful and usable change - awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is a need to serialize or deserialize values for types that were not created within the same assembly. Extension methods don't work to add
ToJsonorFromJsonmethods to these types. In this PR, I useSystem.DayOfWeekas the exemplar, but I plan to use it for serializing types from theNodaTimelibrary. The key change here is to expose theJson -> JsonResult<'a>and'a -> Jsonshaped holes in the read/write functions.Let me know what you think.