Fix deployment action and add ruff-bugbear

.github/workflows/publish-to-pypi.yml

@@ -1,33 +1,50 @@
 # https://github.com/pypa/gh-action-pypi-publish
 name: Publish Python 🐍 distributions 📦 to PyPI and TestPyPI
-on: push
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+  release:
+    types:
+      - published
 jobs:
   build-n-publish:
     name: Build and publish Python 🐍 distributions 📦 to PyPI and TestPyPI
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
-      - name: Set up Python 3.11
-        uses: actions/setup-python@v1
+      - uses: actions/checkout@v3
+
+      - name: Set up Python
+        uses: actions/setup-python@v4
         with:
-          python-version: 3.11
-      - name: Install pep517
-        run: >-
-          python -m
-          pip install
-          pep517
-          --user
-      - name: Build a binary wheel and a source tarball
-        run: >-
-          python -m
-          pep517.build
-          --source
-          --binary
-          --out-dir dist/
-          .
-      - name: Publish distribution 📦 to PyPI
-        if: startsWith(github.event.ref, 'refs/tags')
-        uses: pypa/gh-action-pypi-publish@master
+          python-version: "3.x"
+
+      - name: Get tags
+        run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
+
+      - name: Install build tools
+        run: |
+          python -m pip install --upgrade build
+
+      - name: Build binary wheel
+        run: python -m build --sdist --wheel . --outdir dist
+
+      - name: CheckFiles
+        run: |
+          ls dist
+          python -m pip install --upgrade check-manifest
+          check-manifest --verbose
+
+      - name: Test wheels
+        run: |
+          cd dist && python -m pip install *.whl
+          python -m pip install --upgrade build twine
+          python -m twine check *
+
+      - name: Publish a Python distribution to PyPI
+        if: success() && github.event_name == 'release'
+        uses: pypa/gh-action-pypi-publish@release/v1
         with:
           user: __token__
-          password: ${{ secrets.pypi_password }}
+          password: ${{ secrets.PYPI_PASSWORD }}

pyproject.toml

@@ -37,33 +37,25 @@ write_to = "xpublish_opendap/_version.py"
 [project.entry-points."xpublish.plugin"]
 opendap = "xpublish_opendap.plugin:OpenDapPlugin"
 
-[tool.interrogate]
-ignore-init-method = true
-ignore-init-module = false
-ignore-magic = false
-ignore-semiprivate = false
-ignore-private = false
-ignore-module = false
-fail-under = 95
-exclude = ["setup.py", "docs", "tests"]
-verbose = 1
-quiet = false
-color = true
-
 [tool.ruff]
 select = [
-    "E",  # pycodestyle
-    "F",  # pyflakes
-    "UP", # pyupgrade
-    "D",  # pydocstyle
-    "I",  # isort
-    "PL", # pylint
-    "A",  # flake8-builtins
-    "C4", # flake8-comprehensions
-    # flake8-mutable
+    "A",   # flake8-builtins
+    "B",   # flake8-bugbear
+    "C4",  # flake8-comprehensions
+    "D",   # pydocstyle
+    "E",   # pycodestyle
+    "F",   # pyflakes
+    "I",   # isort
+    "PL",  # pylint
     "T20", # flake8-print
+    "UP",  # pyupgrade
+    "W",   # pycodestyle warnings
 ]
 
 [tool.ruff.pydocstyle]
 # Use Google-style docstrings.
 convention = "google"
+
+[tool.ruff.flake8-bugbear]
+# Allow fastapi.Depends and other dependency injection style function arguments
+extend-immutable-calls = ["fastapi.Depends", "fastapi.Query"]

requirements-dev.txt

@@ -10,6 +10,7 @@ pylint
 pytest
 pytest-cov
 pytest-flake8
+pytest-github-actions-annotate-failures
 pytest-xdist
 recommonmark
 ruff