Fix deployment action and add ruff-bugbear #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @ocefpaf for the suggestions and the fact that I could swipe the actions config from erddapy. Needed to tweak bugbear settings to play nice with FastAPI. astral-sh/ruff#389
|
@ocepaf, if I understand things right, that failed because there aren't any tags on the repo yet? https://github.com/xpublish-community/xpublish-opendap/actions/runs/4844988654/jobs/8633643309#step:5:21 |
Yep. Should work fine when you make one. In hindsight, we add these GHA in old projects and never realized it is, in a way, flawed for new ones without a tag. |
|
Does twine or build need the tags? |
|
I've disabled the workflow for now. |
Nope. Just the start to get the tag but that blocks the other steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @ocefpaf for the suggestions and the fact that I could swipe the actions config from erddapy.
Needed to tweak bugbear settings to play nice with FastAPI. astral-sh/ruff#389