Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why residuals are different between py2 and py3 #260

Closed
sguillot opened this issue Feb 3, 2023 · 1 comment · Fixed by #267
Closed

Investigate why residuals are different between py2 and py3 #260

sguillot opened this issue Feb 3, 2023 · 1 comment · Fixed by #267
Assignees
Labels
bug Something isn't working python3 Issues related to Python3

Comments

@sguillot
Copy link
Contributor

sguillot commented Feb 3, 2023

in tutorial notebooks Modeling.ipynb and Instrument_synergy.ipynb

@sguillot sguillot added bug Something isn't working python3 Issues related to Python3 labels Feb 3, 2023
@thjsal
Copy link
Contributor

thjsal commented Feb 3, 2023

Problem solved! It seems that in the Py3 version, GSL seed was still not fixed properly, so we did not get the exact same result. First of all, I instructed you to give gsl_seed input parameter to a wrong function. Secondly, there is also a bug in the seed implementation which prevents fixing the seed to zero from working (and fixing it to zero is what we need here). I'll create a branch to make corrections to the synthesise functions and the tutorials. I already tested that I can get same residuals with Py3 as with Py2, after those corrections.

@thjsal thjsal linked a pull request Feb 3, 2023 that will close this issue
thjsal added a commit that referenced this issue Feb 6, 2023
* Bug in synthetic data seed setting fixed when seed=0

* Fixes #260; Residuals now same in Py3 tutorials as in Py2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python3 Issues related to Python3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants