Fix bug in fixing seed for synthetic data (#267)

* Bug in synthetic data seed setting fixed when seed=0 * Fixes #260; Residuals now same in Py3 tutorials as in Py2.
xpsi-group · Feb 6, 2023 · 4760c72 · 4760c72
1 parent 9350b0d
commit 4760c72
Show file tree

Hide file tree

Showing 3 changed files with 104 additions and 96 deletions.
diff --git a/docs/source/Instrument_synergy.ipynb b/docs/source/Instrument_synergy.ipynb
diff --git a/docs/source/Modeling.ipynb b/docs/source/Modeling.ipynb
diff --git a/xpsi/tools/synthesise.pyx b/xpsi/tools/synthesise.pyx
@@ -221,7 +221,7 @@ def synthesise_exposure(double exposure_time,
     T = gsl_rng_default
     r = gsl_rng_alloc(T)
 
-    if gsl_seed:
+    if gsl_seed is not None:
         gsl_rng_set(r, gsl_seed);
     else:
         gsl_rng_set(r, time.time());
@@ -440,7 +440,7 @@ def synthesise_given_total_count_number(double[::1] phases,
     T = gsl_rng_default
     r = gsl_rng_alloc(T)
 
-    if gsl_seed:
+    if gsl_seed is not None:
         gsl_rng_set(r, gsl_seed);
     else:
         gsl_rng_set(r, time.time());