DON'T MERGE: Track 4.1 #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable heartbeats by default.
* updated bunny to the latest version The tests are green, but we need to study the interplay between the various new timeout options in the multi threaded bunny implementation. This is still WIP!!! * turn on debug logging for the echo RPC * enable auto recovery to see whether this fixes the CI failures * Revert "enable auto recovery to see whether this fixes the CI failures" This reverts commit c7b4b0e. * don't wait when forcing a connection to close * try killing the reader loop hard * try to collect docker logs * learned how to ignore scenarios * improved logging * colored output * removed require that doesn't work anymore * upgraded bunny * Remove superfluous configuration * Run actions on PRs against every base branch * Update expectation to match new options * Expect logger correctly * Match only a subset of options we're interested in * Update to bunny 2.23 This brings updates to the heartbeat implementation which we should get in. --------- Co-authored-by: David Krentzlin <[email protected]>
|
Closing in favour of #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the bunny update and follow-up changes to make it work with our infrastructure.
Don't merge!
Todo