This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Do not call __exit__ on Zarr store when opening #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomNicholas please take a look Tests were not passing for me locally prior to this fix. Edit: This was a problem with my zarr install -- all tests pass. |
The `with` context when opening the zarr group with result in calling __exit__ on the store when the function completes. This calls `.close()` on ZipStore's, which results in errors: ``` ValueError: Attempt to use ZIP archive that was already closed ```
|
Test added |
for more information, see https://pre-commit.ci
jhamman
reviewed
May 17, 2022
| except zarr.errors.PathNotFoundError: | ||
| subgroup_ds = Dataset() | ||
|
|
||
| # TODO refactor to use __setitem__ once creation of new nodes by assigning Dataset works again |
There was a problem hiding this comment.
@TomNicholas - is this still an issue we need to work around?
jhamman
approved these changes
May 17, 2022
3 tasks
|
@jhamman @TomNicholas thanks!! |
|
@TomNicholas any plans to cut a 0.0.6 release? |
@thewtex I just released 0.0.6 just now! |
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
…ee#90 * Do not call __exit__ on Zarr store when opening The `with` context when opening the zarr group with result in calling __exit__ on the store when the function completes. This calls `.close()` on ZipStore's, which results in errors: ``` ValueError: Attempt to use ZIP archive that was already closed ``` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withcontext when opening the zarr group with result in callingexit on the store when the function completes. This calls
.close()on ZipStore's, which results in errors: