-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set TrimMode to partial if not set #15368
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agocke will these changes work with the .NET 6 linker?
These settings will only work in the .NET 7 SDK. Technically these settings are remapped in the task, so the question is what version of the task is used. |
Note: the SDK change was just merged (dotnet/sdk#26246) so we'll need to merge this soon to keep compat in .NET 7 |
OK, the PR should target the |
Done. Anything else? |
d123956
to
381ca5e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
It looks like this passes except for packaging, which is still waiting for an agent after 4 hours. @rolfbjarne I'll leave it up to you, but I think we should merge this ASAP. Xamarin apps will be broken with the new defaults. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 25 tests failed, 198 tests passed. Failures❌ dotnettests tests
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download ❌ linker tests
Html Report (VSDrops) Download ❌ monotouch tests
Html Report (VSDrops) Download ❌ mtouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download |
Our bots are a bit overloaded this week, so it took some time for the tests to run. Unfortunately there are test failures which look related. I'll have a look today to see if I can figure out what's happening, but I'll be on vacation after today so it's likely this won't be completed/merged until I'm back. Our tests worked fine without these changes though, so I'm not sure apps are that broken, and we're in preview anyway for .NET 7, so it shouldn't be that much of a problem if it takes a while to get this merged. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
🔥 Failed to compare API and create generator diff 🔥 Failed to update apidiff references Pipeline on Agent |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌Failed tests are:
Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 12 tests failed, 211 tests passed. Failures❌ dotnettests tests
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download ❌ linker tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Failures here still look related, we'll need to wait for @rolfbjarne's input. |
Companion to dotnet/linker#2856