Change linker to trim everything by default in 7.0 #26246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new trimmer default will be to trim everything, which will be represented by a new TrimMode called 'full'. The previous behavior will be TrimMode 'partial'. Other options for TrimMode, and the TrimmerDefaultAction property, are deprecated.
agocke
requested review from
captainsafia,
mkArtakMSFT,
TanayParikh and
javiercn
as code owners
|
Counterpart to dotnet/linker#2856 |
sbomer
approved these changes
Jun 27, 2022
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs
Outdated
Show resolved
Hide resolved
…707.1 Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22354.1 -> To Version 7.0.100-1.22357.1
…707.2 Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22354.1 -> To Version 7.0.100-1.22357.2
…e9d-95393ec16cfa' into trimmode
|
Just updated to bring in changes from #26472 |
This was referenced Jul 11, 2022
radical
added a commit
to radical/runtime
that referenced
this pull request
Jul 15, 2022
.. `TrimMode=link`. The `TrimMode` values changed in dotnet/sdk#26246 .
radical
added a commit
to dotnet/runtime
that referenced
this pull request
Jul 15, 2022
…der (#72234) .. `TrimMode=link`. The `TrimMode` values changed in dotnet/sdk#26246 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new trimmer default will be to trim everything, which will be represented
by a new TrimMode called 'full'. The previous behavior will be TrimMode
'partial'. Other options for TrimMode, and the TrimmerDefaultAction property,
are deprecated.
All scenarios where trimming is enabled by default (Blazor WASM, Xamarin) will
be expected to opt-in to the previous behavior using
TrimMode=partial. Consoleapps will use the new
Fullbehavior in net7.0, unless otherwise specified.