[release/6.0.4xx] [dotnet] Make sure to not run the linker when we're on a disconnected Windows build. #15096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Windows build. This also means that we shouldn't load the linker's output. Note that we need to check _LoadLinkerOutput even if we've already disabled the linker, because there may be linker output from a previous (connected) build, and we don't want to load that. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1542438.
vs-mobiletools-engineering-service2
added
backported
bug
rolfbjarne
approved these changes
May 23, 2022
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (only version changes) Pipeline on Agent XAMBOT-1109.Monterey' |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌Failed tests are:
Pipeline on Agent |
dalexsoto
approved these changes
May 23, 2022
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results20 tests failed, 126 tests passed.Failed tests
Pipeline on Agent XAMBOT-1017.Monterey' |
|
Test failures are unrelated (#15077). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also means that we shouldn't load the linker's output. Note that we need
to check _LoadLinkerOutput even if we've already disabled the linker, because
there may be linker output from a previous (connected) build, and we don't
want to load that.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1542438.
Backport of #15076