[dotnet] Make sure to not run the linker when we're on a disconnected Windows build. #15076
Conversation
… Windows build. This also means that we shouldn't load the linker's output. Note that we need to check _LoadLinkerOutput even if we've already disabled the linker, because there may be linker output from a previous (connected) build, and we don't want to load that. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1542438.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API diff (for current PR)ℹ️ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)✅ API Diff from stable .NETXamarin vs .NETGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1044.Monterey' |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results1 tests failed, 56 tests passed.Failed tests
Pipeline on Agent XAMBOT-1105.Monterey |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2558). |
|
/sudo backport release/6.0.4xx |
|
Backport Job to branch release/6.0.4xx Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6188314 for more details. |
… on a disconnected Windows build. (#15096) This also means that we shouldn't load the linker's output. Note that we need to check _LoadLinkerOutput even if we've already disabled the linker, because there may be linker output from a previous (connected) build, and we don't want to load that. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1542438. Backport of #15076 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
This also means that we shouldn't load the linker's output. Note that we need
to check _LoadLinkerOutput even if we've already disabled the linker, because
there may be linker output from a previous (connected) build, and we don't
want to load that.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1542438.