Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VideoToolbox] Remove VTDecompressionSession.Create overload requiring manual reference counting. #14218

Merged

Conversation

rolfbjarne
Copy link
Member

We already have a better overload that does not need manual reference counting.

…g manual reference counting.

We already have a better overload that does not need manual reference counting.
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Feb 22, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests didn't execute on Build. ❌

Tests didn't execute on Build.

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

No test summary was found (something probably failed before the tests could execute)

Pipeline on Agent
Merge da4f5a8 into 66dcb94

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 146 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2708 Passed: 2515 Inconclusive: 11 Failed: 1 Ignored: 192)
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): TimedOut

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 5b7a5ad into 5acea1a

@rolfbjarne
Copy link
Member Author

Test failures are unrelated:

@rolfbjarne rolfbjarne merged commit 2c13696 into xamarin:main Feb 23, 2022
@rolfbjarne rolfbjarne deleted the dotnet-videotoolbox-bad-implementation branch February 23, 2022 22:25
tj-devel709 pushed a commit to tj-devel709/xamarin-macios that referenced this pull request Mar 8, 2022
…g manual reference counting. (xamarin#14218)

We already have a better overload that does not need manual reference counting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants