[VideoToolbox] Remove VTDecompressionSession.Create overload requirin…

…g manual reference counting. (#14218) We already have a better overload that does not need manual reference counting.
dotnet · Feb 23, 2022 · 2c13696 · 2c13696 · vs-mobiletools-engineering-service2 · Feb 24, 2022
1 parent d9a2e9d
commit 2c13696
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/VideoToolbox/VTDecompressionSession.cs b/src/VideoToolbox/VTDecompressionSession.cs
@@ -186,26 +186,27 @@ public static VTDecompressionSession Create (CMVideoFormatDescription formatDesc
 				: null;
 		}
 #endif
-		[Obsolete ("This overload requires that the provided compressionOutputCallback manually CFRetain the passed CMSampleBuffer, use Create(VTDecompressionOutputCallback,CMVideoFormatDescription,VTVideoDecoderSpecification,CVPixelBufferAttributes) variant instead which does not have that requirement.")]
 
+#if !NET
+		[Obsolete ("This overload requires that the provided compressionOutputCallback manually CFRetain the passed CMSampleBuffer, use Create(VTDecompressionOutputCallback,CMVideoFormatDescription,VTVideoDecoderSpecification,CVPixelBufferAttributes) variant instead which does not have that requirement.")]
 		public static VTDecompressionSession? Create (VTDecompressionOutputCallback outputCallback,
 							     CMVideoFormatDescription formatDescription,
 							     VTVideoDecoderSpecification? decoderSpecification = null, // hardware acceleration is default behavior on iOS. no opt-in required.
 							     NSDictionary? destinationImageBufferAttributes = null)
 		{
-#if NET
-			unsafe {
-				return Create (outputCallback, formatDescription, decoderSpecification, destinationImageBufferAttributes, &DecompressionCallback);
-			}
-#else
 			return Create (outputCallback, formatDescription, decoderSpecification, destinationImageBufferAttributes, static_DecompressionOutputCallback);
-#endif
 		}
+#endif // !NET
 
 		public static VTDecompressionSession? Create (VTDecompressionOutputCallback outputCallback,
 							     CMVideoFormatDescription formatDescription,
+#if NET
+							     VTVideoDecoderSpecification? decoderSpecification = null, // hardware acceleration is default behavior on iOS. no opt-in required.
+							     CVPixelBufferAttributes? destinationImageBufferAttributes = null)
+#else
 							     VTVideoDecoderSpecification? decoderSpecification, // hardware acceleration is default behavior on iOS. no opt-in required.
 							     CVPixelBufferAttributes? destinationImageBufferAttributes)
+#endif
 		{
 #if NET
 			unsafe {