Support other design systems #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tvararu
force-pushed
the
config-brand
branch
2 times, most recently
from
6fd2a38 to
376f38b
Compare
|
This seems to be working now for our app. PR is ready for review. |
peteryates
reviewed
Jul 18, 2023
misaka
reviewed
Jul 18, 2023
This allows users to change the `govuk` prefix for classes, to reuse the components with other design systems.
This makes them whitelabelable and allows the use of other design systems.
Update all the component tests to use the new example.
|
Comments addressed and commits squashed into one. |
peteryates
approved these changes
Jul 18, 2023
|
It would be nice as a follow up to include a section in the guide showing off an NHS styled component. We can use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #441 but re-raised from a branch on this repo.
This is mostly identical to the work done in x-govuk/govuk-form-builder#127.
Commits kept separate for each individual component in case it makes it easier to review, but should be squashed up before merge.
Fixes #440.
TODO: