Support other design systems #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to change the `govuk` prefix for classes, to reuse the components with other design systems.
This required removing the BUTTON_ATTRIBUTES and LINK_ATTRIBUTES constants that were being used in the `govuk_link_helper` module.
Update all the component tests to use the new example.
👷 Deploy request for govuk-components pending review.Visit the deploys page to approve it
|
|
Converting this to draft as I'm just testing it locally and it seems like the links don't appear correctly. |
|
I've added you as a collaborator, if you re-raise the PR from a branch the guide will build. Changes look good by the way, really looks like it's taking shape. |
|
Superseded by #442. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly identical to the work done in x-govuk/govuk-form-builder#127.
Commits kept separate for each individual component in case it makes it easier to review, but should be squashed up before merge.
Fixes #440.